Skip to content

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Sep 16, 2025

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Chores
    • Bumped app version to 4.64.1 across mobile platforms and related components to ensure consistent versioning.
    • Users may see the updated version number in app stores and in-app settings.
    • No functional or UI changes included; no action required.

Copy link
Contributor

coderabbitai bot commented Sep 16, 2025

Walkthrough

Project version was changed from 4.65.0 to 4.64.1 across Android, iOS, and JavaScript metadata: Android versionName, iOS MARKETING_VERSION for NotificationService, iOS CFBundleShortVersionString in two Info.plists, and package.json version. No other settings or code were modified.

Changes

Cohort / File(s) Summary
Android version
android/app/build.gradle
defaultConfig.versionName updated from "4.65.0" to "4.64.1".
iOS project MARKETING_VERSION
ios/RocketChatRN.xcodeproj/project.pbxproj
MARKETING_VERSION for NotificationService (Debug/Release) changed from 4.65.0 to 4.64.1.
iOS Info.plists
ios/RocketChatRN/Info.plist, ios/ShareRocketChatRN/Info.plist
CFBundleShortVersionString updated from "4.65.0" to "4.64.1" in both plists.
JavaScript package version
package.json
version changed from "4.65.0" to "4.64.1".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • chore: Bump version to 4.65.0 #6654 — Also updates version fields (Android versionName, iOS MARKETING_VERSION/CFBundleShortVersionString, and package.json version), affecting the same files and properties.

Poem

A hop back one, not forward we run,
From 4.65 to 4.64.1.
I twitch my whiskers, tags aligned,
Versions synced, release defined.
Thump-thump—ship it, neat and done! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "chore: Bump version to 4.64.1" is concise, follows conventional commit style, and accurately reflects the primary change in the diff (version string updates in package.json, Android build.gradle, and iOS Info.plist/project settings), so it communicates the PR's intent clearly to reviewers.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 4.64.1

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2dc07bd and 72997c5.

📒 Files selected for processing (5)
  • android/app/build.gradle (1 hunks)
  • ios/RocketChatRN.xcodeproj/project.pbxproj (2 hunks)
  • ios/RocketChatRN/Info.plist (1 hunks)
  • ios/ShareRocketChatRN/Info.plist (1 hunks)
  • package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build iOS Official / Hold
🔇 Additional comments (5)
ios/RocketChatRN/Info.plist (1)

31-31: iOS marketing version set to 4.64.1 — looks good.

Ensure this is not a downgrade vs the last TestFlight/App Store submission; if 4.65.0 ever shipped, 4.64.1 will be rejected. Also confirm CI increments CFBundleVersion (CURRENT_PROJECT_VERSION) for store uploads.

ios/RocketChatRN.xcodeproj/project.pbxproj (1)

3037-3037: NotificationService MARKETING_VERSION updated to 4.64.1 in Debug/Release.

LGTM. Please also confirm that the NotificationService Info.plist does not hardcode a conflicting CFBundleShortVersionString (it should derive from MARKETING_VERSION).

Also applies to: 3082-3082

android/app/build.gradle (1)

93-93: Android versionName set to 4.64.1.

Verify VERSIONCODE continues to monotonically increase in CI; Play Store requires a strictly higher versionCode even if versionName decreases.

ios/ShareRocketChatRN/Info.plist (1)

29-29: Share extension version aligned to 4.64.1.

For release builds, ensure CFBundleVersion is incremented as well; it’s currently “1”.

package.json (1)

3-3: Tag repo and publish v4.64.1 release notes.

Verified: package.json (line 3) and native targets reflect 4.64.1; no 4.65.0 occurrences found — package.json, android/app/build.gradle:93, ios/RocketChatRN.xcodeproj/project.pbxproj (MARKETING_VERSION @ 3037, 3082), ios/RocketChatRN/Info.plist:31, ios/ShareRocketChatRN/Info.plist:29.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copy link

iOS Build Available

Rocket.Chat 4.64.1.107336

@diegolmello diegolmello marked this pull request as ready for review September 16, 2025 20:14
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant