Skip to content

Conversation

@Yaddalapalli-Charan-Kumar-Naidu
Copy link
Contributor

@Yaddalapalli-Charan-Kumar-Naidu Yaddalapalli-Charan-Kumar-Naidu commented Jan 7, 2026

Proposed changes

This PR fixes mixed-language translation issues in Indian locale files by correcting incorrect translations in Tamil (ta-IN.json) and Telugu (te-IN.json).
Non-native language strings were replaced with proper translations to ensure localization consistency and correct UI rendering.

Issue(s)

Fixes #6889
https://rocketchat.atlassian.net/browse/COMM-115

How to test or reproduce

  1. Open the Rocket.Chat React Native app
  2. Change the app language to Telugu (te-IN) or Tamil (ta-IN)
  3. Navigate through authentication and validation-related screens
  4. Verify that all text is displayed in the correct language script
  5. Ensure no mixed-language text appears

Screenshots

Before (Mixed Language) After (Correct Language)
Telugu before fix Telugu after fix

Note: After screenshots show the same screens rendered with corrected locale strings.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (not applicable)
  • I have added necessary documentation (not applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

This change is limited strictly to locale files and does not affect application logic or behavior.
It improves localization accuracy for Indian language users and prevents incorrect scripts from appearing in production UI.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected Tamil translations to proper localized wording.
    • Updated Telugu translations across UI labels, prompts, and messages for consistency and formality.
    • Fixed Hindi translation phrasing and normalized an error placeholder to ensure consistent message rendering.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 7, 2026

Walkthrough

Updated Indian locale files to replace mixed-language strings with target-language translations: Tamil (ta-IN), Telugu (te-IN), and a placeholder normalization in Hindi (hi-IN). No code or control-flow changes.

Changes

Cohort / File(s) Summary
Tamil locale
app/i18n/locales/ta-IN.json
Replaced a non-Tamil string (Persian/Arabic) with Tamil text for the At_Least_Characters key. Content-only change in localization JSON.
Telugu locale
app/i18n/locales/te-IN.json
Replaced numerous non-Telugu strings (Hindi, Kannada, Malayalam, etc.) with Telugu translations across many UI keys (labels, errors, prompts, accessibility). Content-only changes; review for translation accuracy and placeholder consistency.
Hindi locale (minor)
app/i18n/locales/hi-IN.json
Normalized an error placeholder to {{message}} and replaced one label value (Play) with Hindi verb form. Small content/placeholder changes; verify runtime placeholder usage.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • diegolmello

Poem

🐰 Hop, hop, the strings took flight,

Righted scripts into the light.
Tamil, Telugu, Hindi too—
Each in voice now honest and true.
🥕✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR includes changes to hi-IN.json beyond the scope of issue #6889, which specifically targets only ta-IN and te-IN files. The Hindi locale modifications are out of scope. Consider moving the hi-IN.json changes to a separate PR or clarify if they are part of a broader locale fix initiative referenced in the issue.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR successfully addresses the core requirements from issue #6889: Tamil and Telugu locale files have been corrected with proper native language translations, removing mixed-language issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately reflects the main change: updating translations in three Indian locale files (ta-IN, hi-IN, te-IN) to correct mixed-language translation issues.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Yaddalapalli-Charan-Kumar-Naidu
Copy link
Contributor Author

@diegolmello @OtavioStasiak @Rohit3523
I’ve opened a PR addressing the issue #6889
Whenever you get a chance, could you please review my PR?
I’d really appreciate your feedback. Thanks in advance!

@diegolmello diegolmello changed the title bug: i18n: Update ta-IN and te-IN translations (#6889) fix(i18n): Update ta-IN and te-IN translations (#6889) Jan 7, 2026
@diegolmello diegolmello changed the title fix(i18n): Update ta-IN and te-IN translations (#6889) fix(i18n): Update ta-IN and te-IN translations Jan 7, 2026
@diegolmello
Copy link
Member

Thanks for your contribution, @Yaddalapalli-Charan-Kumar-Naidu!
We're going to review this PR soon 🙏🏼

@Yaddalapalli-Charan-Kumar-Naidu
Copy link
Contributor Author

Thanks a lot for the quick response,
I appreciate you taking the time to review it.
Looking forward to your feedback.

@Rohit3523 Rohit3523 changed the title fix(i18n): Update ta-IN and te-IN translations fix(i18n): Update ta-IN, hi-IN and te-IN translations Jan 8, 2026
@Rohit3523 Rohit3523 requested a deployment to approve_e2e_testing January 10, 2026 13:30 — with GitHub Actions Waiting
@Rohit3523
Copy link
Contributor

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 10, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Rohit3523 Rohit3523 requested a deployment to official_android_build January 10, 2026 13:33 — with GitHub Actions Waiting
@Rohit3523 Rohit3523 requested a deployment to experimental_android_build January 10, 2026 13:33 — with GitHub Actions Waiting
@Rohit3523 Rohit3523 requested a deployment to experimental_ios_build January 10, 2026 13:33 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Mixed Language Translations in Locale Files

3 participants