chore: changelog in beta release #6899
+106
−14
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| name: Generate Release Changelog | ||
|
|
||
| on: | ||
| workflow_call: | ||
|
|
||
| jobs: | ||
| generate-changelog: | ||
| name: Generate changelog | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Generate changelog | ||
| shell: bash | ||
| run: | | ||
| LATEST_RELEASE_TAG=$(git tag --sort=-creatordate | head -n 1) | ||
| git log "$LATEST_RELEASE_TAG"..HEAD --pretty=format:"- %s" --no-merges > changelog.txt | ||
| if [ ! -s changelog.txt ]; then | ||
| echo "- Improvements and bug fixes" > changelog.txt | ||
| fi | ||
|
Comment on lines
+17
to
+26
Contributor
There was a problem hiding this comment. Handle the case when no tags exist in the repository. If the repository has no tags, Proposed fix run: |
LATEST_RELEASE_TAG=$(git tag --sort=-creatordate | head -n 1)
+ if [ -z "$LATEST_RELEASE_TAG" ]; then
+ echo "- Improvements and bug fixes" > changelog.txt
+ exit 0
+ fi
+
git log "$LATEST_RELEASE_TAG"..HEAD --pretty=format:"- %s" --no-merges > changelog.txt
if [ ! -s changelog.txt ]; then
echo "- Improvements and bug fixes" > changelog.txt
fi🤖 Prompt for AI Agents |
||
| - name: Upload changelog artifact | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: release-changelog | ||
| path: changelog.txt | ||
| retention-days: 15 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UTF-8 truncation may produce invalid characters; variables should be quoted.
Two issues:
Byte vs character mismatch: Play Store limit is 500 characters, but
wc -ccounts bytes andhead -ctruncates at byte boundaries. For multi-byte UTF-8 characters (e.g., emojis, accented letters), this could:Unquoted variables:
$BUILD_VERSIONshould be quoted to handle unexpected characters safely.🔧 Proposed fix with character-based truncation
- name: Prepare Play Store changelog metadata if: ${{ inputs.trigger == 'develop' }} run: | mkdir -p android/fastlane/metadata/android/en-US/changelogs if [ -f changelog.txt ]; then - size=$(wc -c < changelog.txt) + # Count characters, not bytes (for UTF-8 safety) + char_count=$(wc -m < changelog.txt) - if [ "$size" -gt 500 ]; then - head -c 497 changelog.txt > android/fastlane/metadata/android/en-US/changelogs/$BUILD_VERSION.txt - printf "..." >> android/fastlane/metadata/android/en-US/changelogs/$BUILD_VERSION.txt + if [ "$char_count" -gt 500 ]; then + # Truncate by characters to avoid breaking UTF-8 + cut -c1-497 changelog.txt > "android/fastlane/metadata/android/en-US/changelogs/${BUILD_VERSION}.txt" + printf "..." >> "android/fastlane/metadata/android/en-US/changelogs/${BUILD_VERSION}.txt" else - cat changelog.txt > android/fastlane/metadata/android/en-US/changelogs/$BUILD_VERSION.txt + cat changelog.txt > "android/fastlane/metadata/android/en-US/changelogs/${BUILD_VERSION}.txt" fi else - printf "Internal improvements and bug fixes" > android/fastlane/metadata/android/en-US/changelogs/$BUILD_VERSION.txt + printf "Internal improvements and bug fixes" > "android/fastlane/metadata/android/en-US/changelogs/${BUILD_VERSION}.txt" fi shell: bash env: BUILD_VERSION: ${{ inputs.BUILD_VERSION }}🤖 Prompt for AI Agents