Skip to content

chore: Merge 4.73.1 into master#7370

Open
diegolmello wants to merge 2 commits into
developfrom
4.73.1
Open

chore: Merge 4.73.1 into master#7370
diegolmello wants to merge 2 commits into
developfrom
4.73.1

Conversation

@diegolmello
Copy link
Copy Markdown
Member

@diegolmello diegolmello commented Jun 1, 2026

Proposed changes

Patch release 4.73.1, cut from develop (current tip) with the version bumped across package.json, android/app/build.gradle, iOS Info.plist (app + share extension), and MARKETING_VERSION in the Xcode project (RocketChatRN + NotificationService).

Important

This PR is opened against develop only to trigger the Build PR CI builds. Do not merge it into develop. Once the builds are approved, the base will be retargeted to master and merged there as the 4.73.1 release.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-1210

How to test or reproduce

  • cat package.json | grep version -> 4.73.1
  • grep versionName android/app/build.gradle -> 4.73.1
  • grep CFBundleShortVersionString -A1 ios/RocketChatRN/Info.plist ios/ShareRocketChatRN/Info.plist -> 4.73.1
  • grep MARKETING_VERSION ios/RocketChatRN.xcodeproj/project.pbxproj -> two 4.73.1 entries (RocketChatRN, NotificationService)

Screenshots

N/A

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

  • Chores
    • Updated app version to 4.73.1 across Android and iOS platforms.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dc43a0a2-f267-4a41-8299-6230ffb079e3

📥 Commits

Reviewing files that changed from the base of the PR and between 07aee52 and cfc2687.

📒 Files selected for processing (5)
  • android/app/build.gradle
  • ios/RocketChatRN.xcodeproj/project.pbxproj
  • ios/RocketChatRN/Info.plist
  • ios/ShareRocketChatRN/Info.plist
  • package.json
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: ESLint and Test / run-eslint-and-test
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2026-02-05T13:55:00.974Z
Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6930
File: package.json:101-101
Timestamp: 2026-02-05T13:55:00.974Z
Learning: In this repository, the dependency on react-native-image-crop-picker should reference the RocketChat fork (RocketChat/react-native-image-crop-picker) with explicit commit pins, not the upstream ivpusic/react-native-image-crop-picker. Update package.json dependencies (and any lockfile) to point to the fork URL and a specific commit, ensuring edge-to-edge Android fixes are included. This pattern should apply to all package.json files in the repo that declare this dependency.

Applied to files:

  • package.json
📚 Learning: 2026-05-07T17:47:14.516Z
Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7303
File: package.json:5-5
Timestamp: 2026-05-07T17:47:14.516Z
Learning: When reviewing pnpm `packageManager` version pins in any `package.json` (e.g., `"packageManager": "pnpm@<version>"`), don’t rely solely on web-search results to determine whether a version exists. For very recently published versions, cross-check the target version against the official pnpm release page (https://github.com/pnpm/pnpm/releases) and the npm registry page for pnpm (https://www.npmjs.com/package/pnpm) before flagging the pinned version as non-existent.

Applied to files:

  • package.json
🔇 Additional comments (5)
package.json (1)

3-3: LGTM!

android/app/build.gradle (1)

93-93: LGTM!

ios/RocketChatRN.xcodeproj/project.pbxproj (1)

2092-2092: LGTM!

Also applies to: 2145-2145

ios/RocketChatRN/Info.plist (1)

29-29: LGTM!

ios/ShareRocketChatRN/Info.plist (1)

22-22: LGTM!


Walkthrough

Version number is decremented from 4.74.0 to 4.73.1 across all platform-specific build manifests: root package.json, Android Gradle defaultConfig, iOS Xcode project MARKETING_VERSION settings, and iOS app Info.plist files for both the main app and notification service extension.

Changes

Platform version bump

Layer / File(s) Summary
Root package version
package.json
Package version field updated from 4.74.0 to 4.73.1.
Android build version
android/app/build.gradle
Android app versionName in defaultConfig updated from 4.74.0 to 4.73.1.
iOS platform versions
ios/RocketChatRN.xcodeproj/project.pbxproj, ios/RocketChatRN/Info.plist, ios/ShareRocketChatRN/Info.plist
iOS Xcode project MARKETING_VERSION for NotificationService target (Debug and Release configurations) and CFBundleShortVersionString in both main app and share extension Info.plist files updated from 4.74.0 to 4.73.1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • RocketChat/Rocket.Chat.ReactNative#7318: Both PRs are release-only version bumps touching the same version fields in android/app/build.gradle, ios/RocketChatRN.xcodeproj/project.pbxproj (MARKETING_VERSION), both iOS Info.plist files (CFBundleShortVersionString), and package.json—moving from 4.74.0→4.73.1 vs 4.72.0→4.73.0.

Suggested labels

type: chore

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: Merge 4.73.1 into master' accurately describes the main objective of the pull request—preparing and merging version 4.73.1 across all project configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • NATIVE-1210: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

# Conflicts:
#	android/app/build.gradle
#	ios/RocketChatRN.xcodeproj/project.pbxproj
#	ios/RocketChatRN/Info.plist
#	ios/ShareRocketChatRN/Info.plist
#	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant