chore: integrate RNRepo prebuilt artifacts to reduce native build times#7382
chore: integrate RNRepo prebuilt artifacts to reduce native build times#7382diegolmello wants to merge 2 commits into
Conversation
Wire Software Mansion's RNRepo (Gradle plugin + CocoaPods plugin) to substitute supported React Native libraries with prebuilt artifacts during the native build, falling back to source when a prebuild is unavailable. Add rnrepo.config.json deny list so libraries carrying native (ObjC/Java/ Kotlin/podspec) patch-package patches keep building from source — prebuilt artifacts would otherwise silently bypass those patches. JS-only patches are unaffected.
diegolmello
had a problem deploying
to
approve_e2e_testing
GitHub Actions
Error
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
WalkthroughThis PR integrates RNRepo into Android and iOS build systems: adds the ChangesRNRepo Build Tool Integration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
package.json (1)
50-50: ⚡ Quick winConsider pinning
@rnrepo/build-toolsto0.1.4for reproducible native installs.
android/build.gradleandios/Podfilealready userequire.resolveto locate the documented artifacts (gradle-plugin/build/libs/prebuilds-plugin.jarandcocoapods-plugin/lib/plugin.rb), so staying on later0.1.xreleases shouldn’t break builds as long as those files remain in the same locations. Pinning to an exact version is still safer if you want to prevent any future^0.1.4updates from introducing changes to those internal paths.Suggested diff
- "`@rnrepo/build-tools`": "^0.1.4", + "`@rnrepo/build-tools`": "0.1.4",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` at line 50, Change the `@rnrepo/build-tools` dependency spec in package.json from the caret range "^0.1.4" to the exact version "0.1.4"; then run your package manager (npm install or yarn install) to update the lockfile (package-lock.json or yarn.lock) and commit both the edited package.json and the updated lockfile so the pinned version is preserved.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@android/build.gradle`:
- Around line 25-32: Wrap the rnrepo resolution and classpath registration so
they are skipped when DISABLE_RNREPO is set: surround the providers.exec(...)
call that sets rnrepoDir and the subsequent classpath
fileTree("${rnrepoDir}/gradle-plugin/build/libs", ...) line with a guard like if
(!System.getenv('DISABLE_RNREPO')) { ... } (or the equivalent Gradle/Groovy
null-check) so require.resolve('`@rnrepo/build-tools/package.json`') is not
invoked and the prebuilds-plugin.jar is not added to the buildscript classpath
when DISABLE_RNREPO is present.
---
Nitpick comments:
In `@package.json`:
- Line 50: Change the `@rnrepo/build-tools` dependency spec in package.json from
the caret range "^0.1.4" to the exact version "0.1.4"; then run your package
manager (npm install or yarn install) to update the lockfile (package-lock.json
or yarn.lock) and commit both the edited package.json and the updated lockfile
so the pinned version is preserved.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1a0a8ac0-e324-4219-a9bc-db63e30dc056
⛔ Files ignored due to path filters (2)
ios/Podfile.lockis excluded by!**/*.lockpnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
android/app/build.gradleandroid/build.gradleios/Podfilepackage.jsonrnrepo.config.json
📜 Review details
🧰 Additional context used
🧠 Learnings (8)
📓 Common learnings
Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6930
File: package.json:101-101
Timestamp: 2026-02-05T13:55:06.688Z
Learning: The RocketChat/Rocket.Chat.ReactNative repository uses a fork of react-native-image-crop-picker (RocketChat/react-native-image-crop-picker) with custom Android edge-to-edge fixes, not the upstream ivpusic/react-native-image-crop-picker package. Dependencies should reference commit pins from the RocketChat fork.
Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6875
File: android/build.gradle:3-8
Timestamp: 2026-03-31T11:59:31.061Z
Learning: In the RocketChat/Rocket.Chat.ReactNative repository, the React Native upgrade helper (https://react-native-community.github.io/upgrade-helper/?from=0.79.4&to=0.81.5) recommends kotlinVersion = "2.1.20", compileSdkVersion = 36, targetSdkVersion = 36, and buildToolsVersion = "36.0.0" in android/build.gradle for the RN 0.79.4 → 0.81.5 upgrade. These are the sanctioned values for this upgrade path and should not be flagged as compatibility concerns.
Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6875
File: android/gradle/wrapper/gradle-wrapper.properties:3-3
Timestamp: 2026-03-31T11:58:54.608Z
Learning: In the RocketChat/Rocket.Chat.ReactNative repository, the React Native upgrade helper (https://react-native-community.github.io/upgrade-helper/) recommends gradle-8.14.3-bin for the React Native 0.79.4 → 0.81.5 upgrade. This is the sanctioned Gradle version for RN 0.81.5 even though it is above Kotlin 2.1.20's "fully supported" Gradle range (≤8.11); Kotlin 2.1.20 docs explicitly allow using newer Gradle versions with a caveat that deprecation warnings may appear.
Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-05-18T14:40:38.892Z
Learning: Applies to **/*.{ts,tsx,js,jsx} : Use rocket.chat/eslint-config base with React, React Native, TypeScript, Jest plugins
📚 Learning: 2026-02-05T13:55:00.974Z
Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6930
File: package.json:101-101
Timestamp: 2026-02-05T13:55:00.974Z
Learning: In this repository, the dependency on react-native-image-crop-picker should reference the RocketChat fork (RocketChat/react-native-image-crop-picker) with explicit commit pins, not the upstream ivpusic/react-native-image-crop-picker. Update package.json dependencies (and any lockfile) to point to the fork URL and a specific commit, ensuring edge-to-edge Android fixes are included. This pattern should apply to all package.json files in the repo that declare this dependency.
Applied to files:
package.json
📚 Learning: 2026-03-31T11:59:31.061Z
Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6875
File: android/build.gradle:3-8
Timestamp: 2026-03-31T11:59:31.061Z
Learning: In the RocketChat/Rocket.Chat.ReactNative repository, the React Native upgrade helper (https://react-native-community.github.io/upgrade-helper/?from=0.79.4&to=0.81.5) recommends kotlinVersion = "2.1.20", compileSdkVersion = 36, targetSdkVersion = 36, and buildToolsVersion = "36.0.0" in android/build.gradle for the RN 0.79.4 → 0.81.5 upgrade. These are the sanctioned values for this upgrade path and should not be flagged as compatibility concerns.
Applied to files:
package.jsonandroid/app/build.gradleandroid/build.gradle
📚 Learning: 2026-03-31T11:58:54.608Z
Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6875
File: android/gradle/wrapper/gradle-wrapper.properties:3-3
Timestamp: 2026-03-31T11:58:54.608Z
Learning: In the RocketChat/Rocket.Chat.ReactNative repository, the React Native upgrade helper (https://react-native-community.github.io/upgrade-helper/) recommends gradle-8.14.3-bin for the React Native 0.79.4 → 0.81.5 upgrade. This is the sanctioned Gradle version for RN 0.81.5 even though it is above Kotlin 2.1.20's "fully supported" Gradle range (≤8.11); Kotlin 2.1.20 docs explicitly allow using newer Gradle versions with a caveat that deprecation warnings may appear.
Applied to files:
package.jsonandroid/app/build.gradleandroid/build.gradle
📚 Learning: 2026-05-18T14:40:38.892Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-05-18T14:40:38.892Z
Learning: React 19.1, React Native 0.81, Expo 54 versions should be used
Applied to files:
package.json
📚 Learning: 2026-05-18T14:40:38.892Z
Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-05-18T14:40:38.892Z
Learning: Applies to **/*.{ts,tsx,js,jsx} : Use rocket.chat/eslint-config base with React, React Native, TypeScript, Jest plugins
Applied to files:
package.json
📚 Learning: 2026-03-30T15:49:30.957Z
Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6875
File: app/containers/RoomItem/Actions.tsx:12-12
Timestamp: 2026-03-30T15:49:30.957Z
Learning: In RocketChat/Rocket.Chat.ReactNative, `react-native-worklets` version 0.6.1 does NOT export a built-in Jest mock (e.g., no `react-native-worklets/lib/module/mock`). The correct Jest mock approach for this version is to add a manual mock in `jest.setup.js`: `jest.mock('react-native-worklets', () => ({ scheduleOnRN: jest.fn((fn, ...args) => fn(...args)) }))`.
Applied to files:
package.json
📚 Learning: 2026-05-07T17:47:14.516Z
Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7303
File: package.json:5-5
Timestamp: 2026-05-07T17:47:14.516Z
Learning: When reviewing pnpm `packageManager` version pins in any `package.json` (e.g., `"packageManager": "pnpm@<version>"`), don’t rely solely on web-search results to determine whether a version exists. For very recently published versions, cross-check the target version against the official pnpm release page (https://github.com/pnpm/pnpm/releases) and the npm registry page for pnpm (https://www.npmjs.com/package/pnpm) before flagging the pinned version as non-existent.
Applied to files:
package.json
| // RNRepo: substitute supported libraries with prebuilt artifacts | ||
| def rnrepoDir = new File( | ||
| providers.exec { | ||
| workingDir(rootDir) | ||
| commandLine("node", "--print", "require.resolve('@rnrepo/build-tools/package.json')") | ||
| }.standardOutput.asText.get().trim() | ||
| ).getParentFile().absolutePath | ||
| classpath fileTree(dir: "${rnrepoDir}/gradle-plugin/build/libs", include: ["prebuilds-plugin.jar"]) |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Does @rnrepo/build-tools0.1.4 honorDISABLE_RNREPO=1 before Gradle/CocoaPods plugin initialization, or only after the plugins have already been resolved/applied?
💡 Result:
Answer: Based on the official rnrepo documentation, DISABLE_RNREPO is checked to “completely skip the RNRepo plugin setup” for a given build, rather than only disabling individual downloads later. The docs indicate that when DISABLE_RNREPO is set (to any value), the plugin will not execute at all for that Gradle/CocoaPods run—so it prevents the RNRepo plugin’s behavior from running during that build lifecycle, not merely after the plugin has already been resolved/applied. Evidence: - The troubleshooting guide states: “If this variable is set to ANY value, the plugin will not execute.” [1] - It further says: “This environment variable takes precedence and will completely skip the RNRepo plugin setup regardless of the Gradle task being executed.” [1] Important nuance: - The documentation confirms “skip setup/execute” behavior, but it does not spell out the exact implementation order relative to Gradle plugin resolution/application phases (i.e., whether the code path avoids all work immediately upon init vs. after the Gradle/CocoaPods plugin entrypoint is invoked). It only guarantees that the plugin won’t execute / setup when DISABLE_RNREPO is set. [1] For reference, official setup/testing commands show using DISABLE_RNREPO with Gradle commands like assembleDebug. [2]
Citations:
- 1: https://github.com/software-mansion/rnrepo/blob/main/TROUBLESHOOTING.md
- 2: https://github.com/software-mansion/rnrepo/blob/main/README.md
Gate rnrepo build-tools resolution/classpath wiring behind DISABLE_RNREPO
@rnrepo/build-tools docs state that when DISABLE_RNREPO is set to any value, the plugin “will not execute / completely skip the RNRepo plugin setup.” However, android/build.gradle still unconditionally runs require.resolve('@rnrepo/build-tools/package.json') and adds prebuilds-plugin.jar to the buildscript classpath during Gradle configuration. That means the documented opt-out may skip plugin behavior, but it does not avoid requiring @rnrepo/build-tools/the jar to be present and resolvable at configuration time—potentially undermining the “source-only” escape hatch.
Wrap the rnrepoDir resolution and classpath fileTree(...) registration in a DISABLE_RNREPO check.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@android/build.gradle` around lines 25 - 32, Wrap the rnrepo resolution and
classpath registration so they are skipped when DISABLE_RNREPO is set: surround
the providers.exec(...) call that sets rnrepoDir and the subsequent classpath
fileTree("${rnrepoDir}/gradle-plugin/build/libs", ...) line with a guard like if
(!System.getenv('DISABLE_RNREPO')) { ... } (or the equivalent Gradle/Groovy
null-check) so require.resolve('`@rnrepo/build-tools/package.json`') is not
invoked and the prebuilds-plugin.jar is not added to the buildscript classpath
when DISABLE_RNREPO is present.
|
Android Build Available Rocket.Chat 4.74.0.109024 Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNSLj8hwNWf6HlQh3_QqOfA4j3pYjscACwAlYP0plw7M2t7lLXNzYHvaKZSnsjmnTh29INYQdfzSkwQzOU6X |
The iOS build failed compiling NitroMmkv (react-native-mmkv) because its provider, NitroModules, was substituted with a prebuilt xcframework while NitroMmkv itself builds from source (no prebuild available). Prebuilt provider + source consumer is an incompatible Swift/C++ module pairing. Force NitroModules from source on iOS so it matches its source-built consumers. Android prebuilds NitroModules without issue, so it is left enabled there.
diegolmello
requested a deployment
to
approve_e2e_testing
GitHub Actions
Waiting
diegolmello
requested a deployment
to
android_build
GitHub Actions
Waiting
1 participant
Proposed changes
Integrate RNRepo (Software Mansion) to reduce native build times. RNRepo substitutes supported React Native libraries with prebuilt artifacts from
packages.rnrepo.orgduring the native build — a Gradle plugin on Android and a CocoaPods plugin on iOS — and falls back to building from source whenever a prebuild isn't available. It's beta and New Architecture only; we're on RN 0.81.5 with New Arch enabled on both platforms, so it's supported.We use the Standard React Native integration path (we have committed
android/+ios/, not Expo CNG):@rnrepo/build-toolsdependency.android/build.gradle;apply plugin: "org.rnrepo.tools.prebuilds-plugin"inandroid/app/build.gradle.requirefor the CocoaPods plugin +rnrepo_post_install(installer)inios/Podfile.Podfile.lockonly changes itsPODFILE CHECKSUM; the app Xcode project is untouched (RNRepo's build phases land in the generated Pods project).rnrepo.config.jsondeny list.Deny list rationale — prebuilt artifacts bypass library source compilation, so any library carrying a native (Objective-C/Java/Kotlin/podspec)
patch-packagepatch must keep building from source, or the patch is silently lost. JS-only patches are unaffected. Entries key on the npm package name and are scoped to the platform whose native source the patch touches:@lodev09/react-native-true-sheet,expo-asset,expo-file-system,expo-font,react-native-callkeep,react-native-webviewreact-native-callkeep,react-native-config-reader,react-native-gesture-handler,react-native-nitro-modules,react-native-webviewTwo iOS entries are not patch-driven:
react-native-webview— its patch is Android-only, but the Podfile has a webview-specificHEADER_SEARCH_PATHSstep and the pod graph uses static frameworks, so it stays source until proven safe.react-native-nitro-modules— a prebuiltNitroModulesis an incompatible Swift/C++ module pairing for its source-built consumerNitroMmkv(react-native-mmkv, which has no prebuild yet). Forcing the provider from source keeps it consistent with its consumers. Android prebuildsNitroModuleswithout issue, so it stays enabled there.Issue(s)
https://rocketchat.atlassian.net/browse/NATIVE-1248
How to test or reproduce
No app/runtime behavior changes — this only affects how native dependencies are built.
pnpm pod-install. Expect[📦 RNRepo] … using pre-built frameworksand[📦 RNRepo] ⊘ Denied from pre-buildslisting the iOS deny entries.cd android && ./gradlew :app:assembleDebug --info. Expect[📦 RNRepo] RNRepo plugin is ENABLEDandPackage <name> is in deny list, skippingfor each denied lib.DISABLE_RNREPO=1.CI build results
NitroModulescouldn't be linked against the source-builtNitroMmkv. The deny-list entry above addresses it; an iOS build re-run is needed to confirm the fix and measure the iOS delta (iOS currently substitutes only ~6 libraries, so its win is expected to be smaller than Android's until the registry grows).Screenshots
N/A — no UI changes.
Types of changes
Checklist
Further comments
No JavaScript/TypeScript changed — only build configuration (
*.gradle,Podfile,package.json,pnpm-lock.yaml) and the newrnrepo.config.json— so the JS unit tests and ESLint/tsc surface are unaffected.When regenerating
ios/Podfile.lock, use bundler (pnpm pod-install) so it stays on the pinned CocoaPods 1.15.2. Depending on the environment,RCT-Folly's spec checksum may harmlessly re-flip — that's pre-existing RN/Folly nondeterminism, not introduced here, and was kept out of this diff.Prebuilt coverage is modest today (more on Android than iOS) because RNRepo is in beta and its registry is still growing; unsupported libraries fall back to source silently, so coverage — and the speedup — improves over time with no further changes on our side.
Summary by CodeRabbit