Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: newNavigation Feature preview #32672

Draft
wants to merge 12 commits into
base: feat/new-navigation
Choose a base branch
from

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Jun 25, 2024

Proposed changes (including videos or screenshots)

  • create newNavigation feature preview
  • duplicate ui-client/Header to HeaderV2
  • re-export ui-client/Header in client/components handling feature preview on/off (v1/v2)
  • re-export fuselage/Contextualbar components in client/components handling feature preview on/off (v1/v2)
  • adjust Header imports to point to client/components

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jun 25, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: 4b692d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 37.80069% with 181 lines in your changes missing coverage. Please review.

Project coverage is 56.56%. Comparing base (560520c) to head (4b692d0).

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           feat/new-navigation   #32672      +/-   ##
=======================================================
- Coverage                56.72%   56.56%   -0.16%     
=======================================================
  Files                     2499     2541      +42     
  Lines                    55380    55643     +263     
  Branches                 11461    11527      +66     
=======================================================
+ Hits                     31416    31477      +61     
- Misses                   21258    21458     +200     
- Partials                  2706     2708       +2     
Flag Coverage Δ
e2e 56.28% <44.00%> (-0.22%) ⬇️
unit 71.55% <0.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti force-pushed the feat/navigation-feature-preview branch from 233a06d to af4389e Compare June 26, 2024 17:32
@juliajforesti juliajforesti force-pushed the feat/navigation-feature-preview branch from 7cd7341 to 72d8151 Compare June 27, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant