Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui-kit): Add tests for types #32678

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

UIKit types are not open for extension, therefore we can't use interface declarations nor enjoy the advantage of the extends construct for them. This pull request add types for assert type shapes in compilation type.

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Jun 26, 2024

⚠️ No Changeset found

Latest commit: 12427c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Jun 26, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.70%. Comparing base (dbc79b7) to head (12427c0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32678   +/-   ##
========================================
  Coverage    56.69%   56.70%           
========================================
  Files         2498     2498           
  Lines        55390    55390           
  Branches     11457    11457           
========================================
+ Hits         31403    31407    +4     
+ Misses       21282    21276    -6     
- Partials      2705     2707    +2     
Flag Coverage Δ
e2e 56.45% <ø> (+<0.01%) ⬆️
unit 71.89% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the refactor/ui-kit-type-assertions branch from 1221caa to 33c28c2 Compare June 27, 2024 03:45
@tassoevan tassoevan marked this pull request as ready for review June 27, 2024 10:02
@tassoevan tassoevan requested a review from a team June 27, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant