Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Room breaking if advanced cron timer is invalid #32687

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Jun 27, 2024

Proposed changes (including videos or screenshots)

If the Advanced cron timer is invalid, the cron will not run, so the message was removed for this case.

Issue(s)

CORE-534

Steps to test or reproduce

Further comments

@gabriellsh gabriellsh requested a review from a team as a code owner June 27, 2024 14:18
Copy link

changeset-bot bot commented Jun 27, 2024

⚠️ No Changeset found

Latest commit: 88e4fbe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Jun 27, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@gabriellsh gabriellsh added this to the 6.10 milestone Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.68%. Comparing base (c3489db) to head (88e4fbe).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32687      +/-   ##
===========================================
- Coverage    56.70%   56.68%   -0.02%     
===========================================
  Files         2498     2494       -4     
  Lines        55390    55315      -75     
  Branches     11457    11445      -12     
===========================================
- Hits         31410    31357      -53     
+ Misses       21275    21258      -17     
+ Partials      2705     2700       -5     
Flag Coverage Δ
e2e 56.44% <80.00%> (-0.03%) ⬇️
unit 71.86% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add tests to ensure the behavior? I think the case that was described in the steps to reproduce would be enough, WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants