Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve unread badge content a11y #33903

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

chore: improve unread badge content a11y #33903

wants to merge 5 commits into from
+41 −39

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Nov 6, 2024 •
edited
Loading

Proposed changes (including videos or screenshots)

  • add aria-hidden to badge content to avoid SR to read content
  • improve sidebar item and badge aria-label

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Nov 6, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33903/
on branch gh-pages at 2024-11-12 18:58 UTC

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.19%. Comparing base (92b6a50) to head (f8403f6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33903   +/-   ##
========================================
  Coverage    75.19%   75.19%           
========================================
  Files          495      495           
  Lines        21601    21601           
  Branches      5362     5362           
========================================
  Hits         16242    16242           
  Misses        4717     4717           
  Partials       642      642
Flag Coverage Δ
unit 75.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: f8403f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@juliajforesti juliajforesti marked this pull request as ready for review November 8, 2024 14:31
@juliajforesti juliajforesti requested a review from a team as a code owner November 8, 2024 14:31
ggazzo
ggazzo reviewed Nov 8, 2024
View reviewed changes
apps/meteor/client/sidebarv2/RoomList/SidebarItemTemplateWithData.tsx
@@ -143,7 +143,7 @@ const SidebarItemTemplateWithData = ({
onClick={(): void => {
!selected && sidebar.toggle();
}}
aria-label={title}
aria-label={showUnread ? `${unreadTitle} ${t('from')} ${title}` : title}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a new i18n

@juliajforesti juliajforesti marked this pull request as draft November 13, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliajforesti @ggazzo