-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improve performance of users.listByStatus
on some circumstances
#33937
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33937 +/- ##
========================================
Coverage 75.20% 75.20%
========================================
Files 495 495
Lines 21595 21595
Branches 5362 5362
========================================
Hits 16240 16240
Misses 4713 4713
Partials 642 642
Flags with carried forward coverage won't be shown. Click here to find out more. |
listByStatus
on some circumstancesusers.listByStatus
on some circumstances
Proposed changes (including videos or screenshots)
$or
filters when no filter is provided, reducing time on returning first page (when the $or clause was passed, even when empty, Mongo was trying to match the regexes against the indexes, making it slow)active
users query, improving speedIssue(s)
https://rocketchat.atlassian.net/browse/CORE-500
Steps to test or reproduce
Further comments