Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve Omnichannel Contact Center routing #33943

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

Currently the contact center routing is messed up with some unnecessary params which turn it difficult to handle the router properly. This PR aims to reduce this complexity to be able to handle the new tabs inside contact info.

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Nov 12, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: 9aaf2ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.19%. Comparing base (5637551) to head (9aaf2ee).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33943   +/-   ##
========================================
  Coverage    75.19%   75.19%           
========================================
  Files          495      495           
  Lines        21601    21601           
  Branches      5362     5362           
========================================
  Hits         16242    16242           
  Misses        4717     4717           
  Partials       642      642           
Flag Coverage Δ
unit 75.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review November 12, 2024 18:21
@dougfabris dougfabris requested a review from a team as a code owner November 12, 2024 18:21
@pierre-lehnen-rc pierre-lehnen-rc added the stat: QA assured Means it has been tested and approved by a company insider label Nov 13, 2024
@dougfabris dougfabris added this to the 7.1.0 milestone Nov 13, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 13, 2024
@kodiakhq kodiakhq bot merged commit 6d4a6be into develop Nov 13, 2024
48 of 49 checks passed
@kodiakhq kodiakhq bot deleted the chore/contact-center-routing branch November 13, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants