Skip to content

regression: improves CalendarEvent status change schedule #35607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 31, 2025

Conversation

ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented Mar 25, 2025

Proposed changes (including videos or screenshots)

This PR ensures that, on application startup, all busy events are correctly scheduled or removed. In a multi-instance setup, the scheduling logic must run on every instance to keep event schedules consistent across the cluster. No explicit locking is required, as the cronJobs package handles concurrency internally.

The schedule function is now triggered in the following scenarios:

  • Creation or import of a new busy event
  • Update to an existing event (time or busy status)
  • Deletion of a busy event
  • Completion of a status change job
  • End of an event (to restore the original status)
  • Outlook Calendar integration activation (ee/server/configuration/outlookCalendar.ts)

The scheduling process includes:

  • Part 1: Schedule all events starting within the next minute
  • Part 2: Ensure in-progress events have scheduled end times (e.g., for server restarts, imported events already in progress, or missed schedules)
  • Part 3: Schedule the next check

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Mar 25, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Mar 25, 2025

⚠️ No Changeset found

Latest commit: 75bf05f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ricardogarim ricardogarim changed the title refactor: improves status change schedule refactor: improves CalendarEvent status change schedule Mar 25, 2025
Copy link
Contributor

github-actions bot commented Mar 25, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35607/

Built to branch gh-pages at 2025-03-31 17:05 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ricardogarim ricardogarim force-pushed the regression/outlook-calendar-events branch from 1485298 to d051493 Compare March 25, 2025 11:49
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 35.82090% with 43 lines in your changes missing coverage. Please review.

Project coverage is 59.66%. Comparing base (68dbd82) to head (75bf05f).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35607      +/-   ##
===========================================
- Coverage    59.72%   59.66%   -0.06%     
===========================================
  Files         2829     2829              
  Lines        68230    68287      +57     
  Branches     15124    15141      +17     
===========================================
- Hits         40748    40742       -6     
- Misses       24874    24934      +60     
- Partials      2608     2611       +3     
Flag Coverage Δ
unit 75.69% <35.82%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ricardogarim ricardogarim marked this pull request as ready for review March 25, 2025 12:38
@ricardogarim ricardogarim requested review from a team as code owners March 25, 2025 12:38
@ricardogarim ricardogarim added this to the 7.5.0 milestone Mar 25, 2025
@ricardogarim ricardogarim changed the title refactor: improves CalendarEvent status change schedule regression: improves CalendarEvent status change schedule Mar 25, 2025
@ricardogarim ricardogarim force-pushed the regression/outlook-calendar-events branch from eb6cdc1 to fdeb189 Compare March 26, 2025 13:27
@ggazzo
Copy link
Member

ggazzo commented Mar 28, 2025

considering the number of lines, methods and the nature of the pr, I would say this is not a regression. s

@MarcosSpessatto MarcosSpessatto added the stat: QA assured Means it has been tested and approved by a company insider label Mar 28, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 28, 2025
ggazzo
ggazzo previously requested changes Mar 28, 2025
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to check what is happening here, its clearly more than a simple correction. putting my change request here just to prevent the ci to merge

@pierre-lehnen-rc
Copy link
Contributor

still missing i18n key for the new setting

@ggazzo ggazzo dismissed their stale review March 31, 2025 14:06

it looks like this time we're going to do an exception

@kodiakhq kodiakhq bot merged commit a2b7b62 into develop Mar 31, 2025
48 checks passed
@kodiakhq kodiakhq bot deleted the regression/outlook-calendar-events branch March 31, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants