-
Notifications
You must be signed in to change notification settings - Fork 11.7k
regression: improves CalendarEvent status change schedule #35607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
1485298
to
d051493
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #35607 +/- ##
===========================================
- Coverage 59.72% 59.66% -0.06%
===========================================
Files 2829 2829
Lines 68230 68287 +57
Branches 15124 15141 +17
===========================================
- Hits 40748 40742 -6
- Misses 24874 24934 +60
- Partials 2608 2611 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
eb6cdc1
to
fdeb189
Compare
considering the number of lines, methods and the nature of the pr, I would say this is not a regression. s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to check what is happening here, its clearly more than a simple correction. putting my change request here just to prevent the ci to merge
still missing i18n key for the new setting |
it looks like this time we're going to do an exception
Proposed changes (including videos or screenshots)
This PR ensures that, on application startup, all busy events are correctly scheduled or removed. In a multi-instance setup, the scheduling logic must run on every instance to keep event schedules consistent across the cluster. No explicit locking is required, as the cronJobs package handles concurrency internally.
The schedule function is now triggered in the following scenarios:
ee/server/configuration/outlookCalendar.ts
)The scheduling process includes:
Issue(s)
Steps to test or reproduce
Further comments