-
Notifications
You must be signed in to change notification settings - Fork 12.2k
fix: formatted volume out of bounds of 0 and 1 #37041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 3924036 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Comment |
22b52f5
to
3924036
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #37041 +/- ##
========================================
Coverage 67.34% 67.34%
========================================
Files 3339 3339
Lines 113178 113179 +1
Branches 20535 20533 -2
========================================
+ Hits 76217 76218 +1
Misses 34355 34355
Partials 2606 2606
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add some unit test
Proposed changes (including videos or screenshots)
Ensures the formatted volume value is kept between 0 and 1
Issue(s)
Steps to test or reproduce
Further comments
CORE-1393