fix(fuselage): OptionIcon not receiving proper icon props (#1522)

RocketChat · Jan 9, 2025 · 0006fe9 · 0006fe9
1 parent 1dc6c86
commit 0006fe9
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/.changeset/tall-rabbits-do.md b/.changeset/tall-rabbits-do.md
@@ -0,0 +1,5 @@
+---
+'@rocket.chat/fuselage': patch
+---
+
+fix: `OptionIcon` not receiving proper icon props
diff --git a/packages/fuselage/src/components/Menu/V2/Menu.stories.tsx b/packages/fuselage/src/components/Menu/V2/Menu.stories.tsx
@@ -56,7 +56,7 @@ export const Complex: StoryFn<typeof Menu> = (args) => (
       <MenuItemContent>Chats</MenuItemContent>
     </MenuItem>
     <MenuItem key='settings'>
-      <MenuItemIcon name='cog' />
+      <MenuItemIcon name='cog' color='font-info' />
       <MenuItemContent>Settings</MenuItemContent>
     </MenuItem>
   </Menu>

diff --git a/packages/fuselage/src/components/Option/OptionIcon.tsx b/packages/fuselage/src/components/Option/OptionIcon.tsx
@@ -4,13 +4,11 @@ import { Icon } from '../Icon';
 
 import OptionColumn from './OptionColumn';
 
-type OptionIconProps = {
-  name: ComponentProps<typeof Icon>['name'];
-};
+type OptionIconProps = ComponentProps<typeof Icon>;
 
-const OptionIcon = ({ name }: OptionIconProps) => (
+const OptionIcon = (props: OptionIconProps) => (
   <OptionColumn>
-    <Icon size='x20' rcx-option__icon name={name} />
+    <Icon size='x20' rcx-option__icon {...props} />
   </OptionColumn>
 );