Skip to content

fix(SelectInput): Prevent placeholder from being selectable in SelectInput#1482

Open
manjeetchandra wants to merge 2 commits intoRocketChat:mainfrom
manjeetchandra:feature/select-input-fix
Open

fix(SelectInput): Prevent placeholder from being selectable in SelectInput#1482
manjeetchandra wants to merge 2 commits intoRocketChat:mainfrom
manjeetchandra:feature/select-input-fix

Conversation

@manjeetchandra
Copy link
Copy Markdown

@manjeetchandra manjeetchandra commented Nov 13, 2024

Proposed changes

Placeholder was getting selected I have fixed that

Issue(s)

#1301

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: 6048a01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 13, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@manjeetchandra manjeetchandra marked this pull request as draft November 13, 2024 19:32
@manjeetchandra manjeetchandra changed the title Fix: Prevent placeholder from being selectable in SelectInput Fix(Select Input logic error): Prevent placeholder from being selectable in SelectInput Nov 13, 2024
@manjeetchandra manjeetchandra changed the title Fix(Select Input logic error): Prevent placeholder from being selectable in SelectInput Fix(SelectInput): Prevent placeholder from being selectable in SelectInput Nov 13, 2024
@manjeetchandra manjeetchandra changed the title Fix(SelectInput): Prevent placeholder from being selectable in SelectInput fix(SelectInput): Prevent placeholder from being selectable in SelectInput Nov 13, 2024
@manjeetchandra manjeetchandra marked this pull request as ready for review November 14, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants