Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fuselage): improve toggling functionality #1485

Closed

Conversation

thepiyush-303
Copy link

Proposed changes (including videos or screenshots)

Issue(s)

closes #1484 ,completely closes #252

Further comments

Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: 07cdf6f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024

CLA assistant check
All committers have signed the CLA.

@thepiyush-303 thepiyush-303 changed the title add handleClick function in SelectAddon feat(fuselage): improve toggling functionality Nov 21, 2024
@dougfabris dougfabris force-pushed the main branch 2 times, most recently from 7548504 to 1a4e891 Compare December 11, 2024 18:31
@thepiyush-303
Copy link
Author

How do i resolve these conflicts?

@dougfabris
Copy link
Member

Hi there, thanks for your contribution 💯 🚀

Your PR doesn't properly fix the issue and we're going to replace this component using another approach more focused on a11y first.

So since it's not a major issue, it won't be fixed!


Questions? Help needed? Feature Requests?

  • Join our Open Server in the #support channel and feel free to raise a question
  • Join our Community Forum and search/create a post there

@dougfabris dougfabris closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiSelect/MultiSelectFiltered: Toggling is not working properly MultiSelect UI/UX issues
3 participants