Skip to content
This repository has been archived by the owner on Oct 30, 2022. It is now read-only.

Issue #95: team-01 - User Interface #114

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

aasitvora99
Copy link

Pull request type

Please check the type of change your PR introduces:

  • Code base additions (bugfix, features)
  • Code maintenance (refactoring, formatting, renaming, tests)
  • ReadMe, Docs and GitHub maintenance
  • Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • ReadMe, Docs and GitHub maintenance:

    • Spelling has been verified
    • Code docs are working correctly
  • Code base maintenance (refactoring, formatting, renaming):

    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally
  • Code base additions (for bug fixes / features):

    • Tests for the changes have been added
    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally

What is the current behavior?

Enter text here...

What is the new behavior?

Enter text here...

Does this introduce a breaking change?

  • Yes
  • No

Other information

Enter text here...

@Gui-FernandesBR Gui-FernandesBR changed the title Issue#95:team-01 Issue #95: team-01 - User Interface Aug 29, 2022
@Gui-FernandesBR Gui-FernandesBR removed the request for review from giovaniceotto August 29, 2022 05:43
@Gui-FernandesBR Gui-FernandesBR linked an issue Aug 29, 2022 that may be closed by this pull request
@Gui-FernandesBR Gui-FernandesBR requested a review from luimot August 29, 2022 05:46
@luimot
Copy link

luimot commented Sep 1, 2022

Hello @aasitvora99 , thank you for your submission of this Issue.
I have tested the home and addEnvironment python pages in streamlit, didn't know this library nor have ever used it but seems a really cool and easy way to implement visual functionalities through python, still, the addMotor and addRocket were not implemented and the ability to save the specification given by the user also were not created, therefore I can't give you the points associated to a Hard task, still I liked a lot your code and the strategy for creating the Interface and hope that you can contribute to RocketPy in the future!

@Gui-FernandesBR
Copy link
Member

Hello @aasitvora99 , thank you for your submission of this Issue. I have tested the home and addEnvironment python pages in streamlit, didn't know this library nor have ever used it but seems a really cool and easy way to implement visual functionalities through python, still, the addMotor and addRocket were not implemented and the ability to save the specification given by the user also were not created, therefore I can't give you the points associated to a Hard task, still I liked a lot your code and the strategy for creating the Interface and hope that you can contribute to RocketPy in the future!

Thank you @luimot for a solid review.
This is indeed a not completed pull request, and some features were lacking at the final submission.
However, taking time to try solving such a hard pull request in a 48 hours hackathon was definetely a chellenge. I'd like to recognize @aasitvora99 's effort here, it was a good pull request at the end.

With that in mind, I am associating points as if it was a medium task.

@Gui-FernandesBR Gui-FernandesBR added 25 points Medium challenges! Hard and removed Hard labels Sep 3, 2022
@giovaniceotto giovaniceotto added penalty Solutions poorly documented or badly coded extra_points Exceptionally ingenious solutions team-01 and removed penalty Solutions poorly documented or badly coded labels Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
25 points Medium challenges! extra_points Exceptionally ingenious solutions team-01
Projects
Development

Successfully merging this pull request may close these issues.

Simple Choice Interface
5 participants