Issue #01: team-02 - Add aero surface info to Rocket.allinfo()

[SullivanMuse]

Pull request type

Please check the type of change your PR introduces:

• Code base additions (bugfix, features)
• Code maintenance (refactoring, formatting, renaming, tests)
• ReadMe, Docs and GitHub maintenance
• Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

• ReadMe, Docs and GitHub maintenance:

  • Spelling has been verified
  • Code docs are working correctly

• Code base maintenance (refactoring, formatting, renaming):

  • Docs have been reviewed and added / updated if needed
  • Lint (black rocketpy) has passed locally and any fixes were made
  • All tests (pytest --runslow) have passed locally

• Code base additions (for bug fixes / features):

  • Tests for the changes have been added
  • Docs have been reviewed and added / updated if needed
  • Lint (black rocketpy) has passed locally and any fixes were made
  • All tests (pytest --runslow) have passed locally

What is the current behavior?

The Rocket.allinfo method prints a lot of info about the Rocket configuration.

Hackathon Issue #1

What is the new behavior?

The Rocket.allinfo method now prints additional information regarding the aerodynamic surfaces, including extra info for those created via Rocket.addFins.

Does this introduce a breaking change?

• Yes
• [*] No

Other information

[Gui-FernandesBR]

Really good result!

[Gui-FernandesBR]

In the above example, we had the following parameters:

{
'cp': (0, 0, 0.9988549999999999),
'cl': Function from R2 to R1: (Alpha(rad), Mach)→(Cl),
'name': 'Nose Cone'
}, {
'cp': (0, 0, -1.10456),
'cl': Function from R2 to R1: (Alpha(rad), Mach)→(Cl),
'roll parameters': [Function from R1 to R1: (x)→(Scalar), Function from R1 to R1: (x)→(Scalar), 0.0],
'name': 'Fins',
'addFins parameters': {
'n': 4,
'span': 0.1,
'rootChord': 0.12,
'tipChord': 0.04,
'distanceToCM': -1.04956,
'radius': 0.0635,
'cantAngle': 0,
'airfoil': None
}
}, {
'cp': (0, 0, -1.2227868411214953),
'cl': Function from R2 to R1: (Alpha(rad), Mach)→(Cl),
'name': 'Tail'
}

[Gui-FernandesBR]

Expected behavior after accpeting changes:

Overall, a very good pull request, simple to review and ]understand, congratulations and Thank You @SullivanMuse !!

[Gui-FernandesBR]

I would suggest a minor change here so the user can better visualize the outputs:

Suggested change

	print(self.aerodynamicSurfaces)
	for surface in self.aerodynamicSurfaces:
	if 'name' in surface:
	print(surface['name'])
	else:
	print('Unnamed Surface:')
	print(surface)

[Gui-FernandesBR]

The 10 points label was added, task is completed!
Let us know if you want to accept changes, but they are not mandatory for the hackathon.

[Gui-FernandesBR]

May recieve an extra 20% points since it was the onlly team solving this challege