Fin flutter analysis algorithm #873
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ENH: use 313 rotation * TST: fix tests * DOC: fix notebook * DEV: changelog * MNT: black on notebooks
…urfaces-pylint ENH: generic surfaces pylint
DEV: Updates master to prepare v1.5.0
…urface DOC: Generic Surface
REL: bumps rocketpy version to v1.5.0
Make format didn't work. Will run it after review and fixes.
Make format didn't work. Will run it after review and fixes.
* ENH: refactor motor prints classes to inherit from _MotorPrints * STY: make format * MNT: update code and remove deprecated functions * ENH: add deprecation decorator and update deprecated methods * make format * fix warnings
* DEV: add GitHub Copilot instructions for codebase consistency and development practices * Final adjustments instructions
…cketPy-Team#839) * BUG: fix StochasticNoseCone powerseries issue by adding power parameter to constructor * DOC: Add bug fix RocketPy-Team#838 to changelog * BUG: pass power parameter into StochasticModel to allow variation
* ENH: add an option to discretize callable sources encoding. * TST: implement testing for discretized encoding. * ENH: allow for disallowing pickle on encoding. * MNT: Update CHANGELOG. * MNT: change pickle encoding name to allow_pickle and test it. * MNT: Tweak the discretization bounds. --------- Co-authored-by: Mateus Stano Junqueira <[email protected]> Co-authored-by: Gui-FernandesBR <[email protected]>
…Team#841) * DOC: Add Flight class usage documentation and update index * DOC: improve flight docs page documentation * DEV: Add Flight class usage documentation entry to CHANGELOG * DOC: Add Flight class usage documentation and update index DOC: improve flight docs page documentation DEV: Add Flight class usage documentation entry to CHANGELOG * DOC: improve flight class documentation page
…y to Flight object (RocketPy-Team#844) ## Pull request type - [x] Code changes (bugfix, features) - [x] Code maintenance (refactoring, formatting, tests) ## Checklist - [ ] Tests for the changes have been added (if needed) - [ ] Docs have been reviewed and added / updated - [ ] Lint (`black rocketpy/ tests/`) has passed locally - [ ] All tests (`pytest tests -m slow --runslow`) have passed locally - [ ] `CHANGELOG.md` has been updated (if relevant) ## Current behavior Passing initial_solution to a Flight object raises `AttributeError: 'Flight' object has no attribute 't_initial'` when running a simulation involving a controller. Attempt to run [this script](https://github.com/werocketry/airbrakes-lookuptable-generator/blob/main/main.py) to reproduce. ## New behavior Initializes t_initial in __init_flight_state when an array is provided as the initial solution. As a result, a simulation can successfully run from an initial condition when controllers are used. Additionally, minor fixes to docstrings in Flight.py ## Breaking change - [ ] Yes - [x] No
…am#842) * MNT: Addition of ensemble variable to ECMWF dictionaries * DEV: Update changelog --------- Co-authored-by: Mateus Stano Junqueira <[email protected]>
* ENH: added radius and porosity to parachute * ENH: added parachute radius * ENH: fixing radius and height attribute in flight class * STY: ruff formatting * TST: updated test value due to gravity update in u_dot_parachute * ENH: added new parameters into add_parachute method in Rocket class * DOC: added new parameters to the documentation * TST: updated test values to match the right gravity model * DOC: improved descriptions of the new parameters * ENH: added new parameters to the stochastic parachute * ENH: implementing previous comments * ENH: fixing formatting and adding docs * ENH: added ka property to Parachute class * ENH: fixing variable name * ENH: fixed attribute name * ENH: simplifying variable names * DOC: adding parameters documentation into StochasticParachute description * ENH: changing ma calculation and porosity documentation from previous comments * TST: updated test value due to change in ma calculation * ENH: changing parameter ka to added_mass_coefficient * DOC: updating the CHANGELOG * ENH: properly substituted all ka parameters for added_mass_coefficient
* ENH: add an option to discretize callable sources encoding. * ENH: allow for disallowing pickle on encoding. * MNT: Update CHANGELOG. * ENH: support for air brakes, controller and sensors encoding. * STY: solve linting and style remarks. * BUG: parachute callbacks attribute naming. * GIT: test agg backend for matplotlib workflows. * TST: include sensors and controllers encoding tests as non slow. * MNT: change recursive to iterative approach on hash search.
…ocketPy-Team#852) * ENH: add time variable density to Tank Fluids. * TST: add tests for variable fluid density. * STY: running isort for import order consistency. * DOC: update Fluid docs with variable density explanations. * MNT: use Union is Fluid dataclass type for Python <3.10 support. * ENH: add time variable density to Tank Fluids. * STY: running isort for import order consistency. * MNT: use Union is Fluid dataclass type for Python <3.10 support. * MNT: refactor density variation for temperature and pressure inputs. * MNT: improve Tank class outputs (WIP). * DOC: update fluid density documentation. * MNT: Add CAD data for tank geometry validation. * MNT: Refactor tank testing and improve file structure. * MNT: add recent changes to CHANGELOG. * MNT: post merge fixes from testing refactors. * MNT: post rebase fixes. * TST: introduce testing to variable density tanks. * MNT: Add recent changes to CHANGELOG. * TST: improve fluid tests and solve review comments.
* mnt: extract flight data exporters into FlightDataExporter with deprecation wrappers * tst: add unit tests for exporter delegation and direct exports * tst: minor tweaks to clean up imports on added tests * doc: switch export examples to FlightDataExporter and note deprecations (KML, CSV) * doc(changelog): record FlightDataExporter extraction, deprecations, and doc updates * format flight.py with ruff to comply with project style * TST: Improve tests for Flight Data Exporter * FIx commentaries * Fix lint --------- Co-authored-by: Gui-FernandesBR <[email protected]>
* ENH: Changed the ellipses labels * ENH: Adjusted the relative positioning so it doesn't rescale with border size * ENH: Changed the ellipses labels * ENH: Adjusted the relative positioning so it doesn't rescale with border size * DOC: Updated the CHANGELOG
* MNT: Bump minimum python version to 3.10 * change python version for tests * changes more versions of python * trying to pass CI * python 3.4 still note ready * GIT: change workflows to retry Python 3.14. * MNT: Update CHANGELOG. --------- Co-authored-by: Pedro Bressan <[email protected]>
No breaking changes, the code is the same, the coverage is the same. But it is easier to navigate through files now!
Co-authored-by: Gui-FernandesBR <[email protected]>
Co-authored-by: Mateus Stano Junqueira <[email protected]>
Update master with develop to release v1.11.0
REL: bumps up rocketpy version to 1.11.0
Member
|
Hello @jvthecreator , thank you for pulling this up. I'm afraid to say this PR does not follow the the contribution guidelines stated at this repo. Please refer to the development documentation https://docs.rocketpy.org/en/latest/development/index.html and try to open another PR please The following figure tell us something is really wrong with the PR. It's not possible to be merging the 2240 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
23 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a contribution from the "Projeto Júpiter" team, specifically aimed at the simulations of the "Odisseia II" rocket (mission ID 42), to the fin flutter analysis according to what is published in NACA technical paper 4197. The code consists of a direct application of the algorithms that relate the fin loading and vibration according to the fin velocity.
Fin_flutter_analysis.ipynb