Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Improvement of stored results parameters #20

Merged
merged 8 commits into from
Jun 15, 2024
Merged

ENH: Improvement of stored results parameters #20

merged 8 commits into from
Jun 15, 2024

Conversation

juliomachad0
Copy link
Member

No description provided.

@juliomachad0 juliomachad0 self-assigned this Jun 15, 2024
Gui-FernandesBR
Gui-FernandesBR requested changes Jun 15, 2024
View reviewed changes
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR, I think it solves the problem.

I'm still testing it locally, but I think it might be working.

I've made some small comments.

open_rocket_serializer/components/stored_results.py Outdated Show resolved Hide resolved
rocketserializer/components/stored_results.py Outdated Show resolved Hide resolved
rocketserializer/components/stored_results.py Outdated Show resolved Hide resolved
@Gui-FernandesBR Gui-FernandesBR self-requested a review June 15, 2024 17:08
@Gui-FernandesBR Gui-FernandesBR merged commit cb66e8e into master Jun 15, 2024
5 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the enh/improve_stored_results_parameters branch June 15, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gui-FernandesBR Gui-FernandesBR Gui-FernandesBR approved these changes

Assignees

@juliomachad0 juliomachad0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliomachad0 @Gui-FernandesBR