feat: check duplicated values #20
Conversation
|
@Rodsevich |
|
Hey @ronnnnn ! I'll happily do this today. Thanks for the PR! |
|
@Rodsevich |
There was a problem hiding this comment.
I'm thinking that taking the "check duplicates" command of the package just for values would be sortta bully, because somebody would eventually need to check keys/values/both (/documentations/@keywords/@@keywords/whatever) and he wouldn't be able to do so because the check duplicates oly checks for values. I think the best approach for solving that is creating subcommands on the duplicates subcommand and there add this logic for values or adding options to the duplicates subcommand to enable/disable what to check for, with just the values defaulted to true.
Note that if you want to add the other subcommands/options, you are welcome, but I'm just requesting for you the architectural support for subcommands over the duplicates subcommand, specifically the values. So, the client will launch the command arb_utils check duplicates values or arb_utils check duplicates --values for using your feature, leaving room for another user that would need to check for keys by using arb_utils check duplicates keys or arb_utils check duplicates --no-values --keys.
What do you think?
|
|
||
| final file = File(filePaths.first); | ||
| if (!await file.exists()) { | ||
| print(red('ERROR! File ${file.path} does not exists')); |
There was a problem hiding this comment.
| Map<String, dynamic> checkDuplicatesARB(String arbContent) { | ||
| final Map<String, dynamic> arbJsonMap = json.decode(arbContent); | ||
| arbJsonMap.removeWhere((key, value) => key.startsWith('@@')); | ||
| arbJsonMap.removeWhere((key, value) => key.startsWith('@')); |
There was a problem hiding this comment.
I don't think it'd be necessary to avoid the @keys
| final Map<String, dynamic> arbJsonMap = json.decode(arbContent); | ||
| arbJsonMap.removeWhere((key, value) => key.startsWith('@@')); | ||
| arbJsonMap.removeWhere((key, value) => key.startsWith('@')); | ||
| arbJsonMap.removeWhere((key, value) { |
There was a problem hiding this comment.
what's the intention of this code? write it down on a //comment
Are you sure the regexp works for every fomatting of the .arb? You'll have to format it before processing or improve the RegExp, maybe with \s\S
| } | ||
| } | ||
| '''; | ||
| const noDuplicatedArb = ''' |
| import 'package:args/command_runner.dart'; | ||
| import 'package:dcli/dcli.dart'; | ||
|
|
||
| class CheckDuplicatesCommand extends Command { |
There was a problem hiding this comment.
must be named CheckDuplicatesSubcommand
|
I agree with your approach. |
Overview
Add
checkcommand andduplicatessub command to find duplicated values.Use Case
Large arb file or many arb files make difficult to find duplicated values.
To find them easily, add the commands on arb_utils.
Review Points
duplicatescommand as sub command to make easy to add another commands oncheckcommand.@@, at first.