-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Fixes #134
Minor Fixes #134
Conversation
Scipy 1.13 some functions moved around
@singjc ideally we can do a quick release with these changes like version 0.91 for these minor changes. Currently tests fail because of recent scipy bump |
Yeah think we can do this. There is a github action that you have to trigger manually to bump the version. But I think the script currently bumps the patch version by a whole number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can you add the specific version constraint for scipy in the requirements, setup.cfg and project.toml.
@@ -8,7 +8,8 @@ | |||
|
|||
# Data modules | |||
import numpy as np | |||
from scipy.signal import savgol_filter, gaussian, convolve | |||
from scipy.signal import savgol_filter, convolve | |||
from scipy.signal.windows import gaussian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the specific version dependency for scipy in requirements, setup.cfg and project.toml?
Actually, I think it's okay if we bump by whole number,, because it's just a patch. So v0.010, otherwise it would be first initial version with 91 patches? |
sounds good we can do version 0.0.10 |
Description
Fix import errors that occur with recent version of scipy
Fix typos
Fix deprecation warnings
Contents (#134)
Other
Uncategorised!