Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Fixes #134

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Minor Fixes #134

merged 4 commits into from
Apr 9, 2024

Conversation

jcharkow
Copy link
Collaborator

@jcharkow jcharkow commented Apr 5, 2024

Description

Fix import errors that occur with recent version of scipy

Fix typos

Fix deprecation warnings

Contents (#134)

Other

  • deprecation in latest scipy
  • deprecation (replace warn --> warning)
  • typo

Uncategorised!

  • update scipy version in configs

@jcharkow
Copy link
Collaborator Author

jcharkow commented Apr 5, 2024

@singjc ideally we can do a quick release with these changes like version 0.91 for these minor changes. Currently tests fail because of recent scipy bump

@jcharkow jcharkow requested a review from singjc April 5, 2024 15:13
@singjc
Copy link
Collaborator

singjc commented Apr 5, 2024

@singjc ideally we can do a quick release with these changes like version 0.91 for these minor changes. Currently tests fail because of recent scipy bump

Yeah think we can do this. There is a github action that you have to trigger manually to bump the version. But I think the script currently bumps the patch version by a whole number.

Copy link
Collaborator

@singjc singjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add the specific version constraint for scipy in the requirements, setup.cfg and project.toml.

@@ -8,7 +8,8 @@

# Data modules
import numpy as np
from scipy.signal import savgol_filter, gaussian, convolve
from scipy.signal import savgol_filter, convolve
from scipy.signal.windows import gaussian
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the specific version dependency for scipy in requirements, setup.cfg and project.toml?

@singjc
Copy link
Collaborator

singjc commented Apr 5, 2024

@singjc ideally we can do a quick release with these changes like version 0.91 for these minor changes. Currently tests fail because of recent scipy bump

Yeah think we can do this. There is a github action that you have to trigger manually to bump the version. But I think the script currently bumps the patch version by a whole number.

Actually, I think it's okay if we bump by whole number,, because it's just a patch. So v0.010, otherwise it would be first initial version with 91 patches?

@jcharkow
Copy link
Collaborator Author

jcharkow commented Apr 5, 2024

sounds good we can do version 0.0.10

@jcharkow jcharkow merged commit cfb9cd3 into dev Apr 9, 2024
11 checks passed
@jcharkow jcharkow deleted the fix/scipy-bump branch April 9, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants