Add support for buffer protocol (PEP 688) #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PEP 688 being accepted and included in Python 3.12, we should accept and test for custom classes implementing the buffer protocol being passed to
Parser
.Moreover, static type checkers will stop promoting
bytearray
/memoryview
/etc. tobytes
at some point, so let's anticipate that (has been tested with custom version of mypy).Mypy patch
Errors messages in current version with patched mypy