fix: cause check should return true on granting (#397)

RoinujNosde · Aug 3, 2023 · f29bc74 · f29bc74
1 parent e12ee8a
commit f29bc74
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/main/java/net/sacredlabyrinth/phaed/simpleclans/managers/PermissionsManager.java b/src/main/java/net/sacredlabyrinth/phaed/simpleclans/managers/PermissionsManager.java
@@ -267,8 +267,10 @@ public boolean grantPlayer(OfflinePlayer player, double money) {
      */
     public boolean grantPlayer(@NotNull OfflinePlayer player, double money, @Nullable Cause cause) {
         EconomyResponse response = Objects.requireNonNull(economy, "Can't find economy provider").depositPlayer(player, money);
-        if (!response.transactionSuccess() || cause == null) {
+        if (!response.transactionSuccess()) {
             return false;
+        } else if (cause == null) {
+            return true;
         }
 
         EconomyTransactionEvent event = new EconomyTransactionEvent(player, response.amount, cause, EconomyTransactionEvent.TransactionType.DEPOSIT);