[Aikido] Fix security issue in mysql2 via major version upgrade from 2.1.0 to 3.17.0 in server#32
Open
aikido-autofix[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade mysql2 to fix critical Remote Code Execution vulnerabilities in parameter validation and High severity Prototype Pollution and SQL injection issues.
✅ Code not affected by breaking changes.
✅ No breaking changes from the mysql2 upgrade affect this codebase.
The security fix in version 3.17.0 addresses SQL injection bypass through objects passed in queries. However, this codebase:
Uses Sequelize ORM as the primary database interface (not raw mysql2 queries)
The only direct
db.query()call found inserver/routes/index.js:47uses string interpolation with template literals, not parameterized queries with objectsNo instances were found where objects are passed as query parameters to mysql2 methods
The codebase does not use the affected pattern (passing objects in queries), so the security fix will not restrict any existing functionality.
All breaking changes by upgrading mysql2 from version 2.1.0 to 3.17.0 (CHANGELOG)
✅ 6 CVEs resolved by this upgrade, including 2 critical 🚨 CVEs
This PR will resolve the following CVEs:
readCodeForfunction (lib/parsers/text_parser.js and lib/parsers/binary_parser.js) due to improper validation of the 'timezone' value.readCodeForfunction, due to improper validation of thesupportBigNumbersandbigNumberStringsvalues. This vulnerability is exploitable when using user-defined database connections.mysql2package prior to 3.9.4 are vulnerable to prototype poisoning due to insecure creation of the results object and improper sanitization of user input passed through theparserFnintext_parser.jsandbinary_parser.js.🔗 Related Tasks