Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Display access key as a regular string #480

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

annavik
Copy link
Member

@annavik annavik commented Aug 2, 2024

Frontend is prepared now, we just need to include the key with API response @mihow! :)

Fixes #474

@annavik annavik changed the title [Draft]: Display access key as a regular string [Draft] Display access key as a regular string Aug 2, 2024
@annavik annavik requested a review from mihow August 2, 2024 15:50
Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit 3bf1d3b
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/66c7bd377ffba50008f75404
😎 Deploy Preview https://deploy-preview-480--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for ami-dev ready!

Name Link
🔨 Latest commit d8cdeee
🔍 Latest deploy log https://app.netlify.com/sites/ami-dev/deploys/677bf58877cf5b00087de6ad
😎 Deploy Preview https://deploy-preview-480--ami-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 73
Accessibility: 89
Best Practices: 92
SEO: 100
PWA: 80
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@mihow mihow self-assigned this Aug 2, 2024
@mihow
Copy link
Collaborator

mihow commented Aug 5, 2024

Note for myself: I think the detail view for the data sources should not be public, only the list view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not display access key as a secret
2 participants