Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Feb 15, 2025

Important

Update documentation to clarify global vs. project-specific custom modes, configuration locations, and precedence rules.

  • Documentation Update:
    • Clarifies that custom modes can be global or project-specific in custom-modes.md.
    • Specifies configuration locations: cline_custom_modes.json for global, .roomodes for project-specific.
    • Notes project-specific modes take precedence over global modes with the same slug.
    • Mentions UI limitation: file type restrictions not supported in prompts tab.

This description was created by Ellipsis for 380fe1a. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e897187 in 1 minute and 7 seconds

More details
  • Looked at 43 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. docs/advanced-usage/custom-modes.md:36
  • Draft comment:
    Good update clarifying that file type restrictions cannot be edited via the prompts tab UI. Removing the step for adding file restrictions prevents users from expecting unsupported functionality.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment seems to be informative, explaining the consequence of removing a step. It doesn't suggest a specific code change or ask for confirmation of intent. It doesn't align with the rules for useful comments.
2. docs/advanced-usage/custom-modes.md:44
  • Draft comment:
    The manual configuration section now clearly distinguishes between global and project-specific configurations. This improves clarity about configuration precedence. Consider adding a brief example or note on how conflicts are resolved when both configurations are present.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 20% <= threshold 50%
    This comment is asking for additional documentation or clarification on how conflicts are resolved between global and project-specific configurations. It is not directly related to code quality or functionality, and it seems to be more of a suggestion for documentation improvement. According to the rules, purely informative comments or requests for additional documentation are not allowed.
3. docs/advanced-usage/custom-modes.md:39
  • Draft comment:
    Removed the 'Add File Restrictions' step and added a note indicating that file type restrictions are not yet supported in the prompts tab UI. This clearly communicates the current limitation—ensure to update the docs once this feature is implemented.
  • Reason this comment was not posted:
    Marked as duplicate.
4. docs/advanced-usage/custom-modes.md:45
  • Draft comment:
    Updated the manual configuration instructions to clearly distinguish between global and project-specific configurations, including their file locations and precedence. This enhancement improves clarity for advanced users.
  • Reason this comment was not posted:
    Marked as duplicate.
5. docs/advanced-usage/custom-modes.md:57
  • Draft comment:
    Removed the explicit reference to VS Code in the 'Open the Settings File' step in favor of a more generic instruction. This makes the documentation editor-agnostic and more inclusive for users with different setups.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is purely informative, explaining a change made to the documentation. It doesn't provide a suggestion, ask for confirmation, or point out a potential issue. According to the rules, purely informative comments should be removed.

Workflow ID: wflow_BBrovHhiJS6MEP3j


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 380fe1a in 46 seconds

More details
  • Looked at 51 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 drafted comments based on config settings.
1. docs/advanced-usage/custom-modes.md:43
  • Draft comment:
    Good job adding clarity on global vs project-specific custom modes. The details about file locations and precedence are very helpful.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
2. docs/advanced-usage/custom-modes.md:36
  • Draft comment:
    Removing the file restrictions step in the Prompts Tab and adding a note about its lack of support is a clear update. Ensure that future documentation updates reflect any eventual UI changes.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
3. docs/advanced-usage/custom-modes.md:1
  • Draft comment:
    Good update clarifying global vs project-specific modes. Consider briefly noting if the global config path may vary by OS.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
4. docs/advanced-usage/custom-modes.md:41
  • Draft comment:
    Great job flagging that file type restrictions are not supported in the UI. Consider mentioning that such restrictions may be configurable manually if supported later.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
5. docs/advanced-usage/custom-modes.md:65
  • Draft comment:
    The JSON sample is clear. For added clarity, consider a brief explanation of the 'groups' field's structure (e.g. differentiating simple strings from arrays with regex rules) to help less experienced users.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None

Workflow ID: wflow_x5Tt62d916R6u3GP


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@mrubens mrubens merged commit e606b11 into main Feb 15, 2025
2 checks passed
@mrubens mrubens deleted the roomodes branch February 15, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants