Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Feb 15, 2025

Important

Enhance footer in docusaurus.config.ts with new GitHub and Download sections.

  • Footer Enhancements:
    • Added new 'GitHub' section with links to 'Issues' and 'Feature Requests'.
    • Added new 'Download' section with links to 'VS Code Marketplace' and 'Open VSX Registry'.

This description was created by Ellipsis for 9f1d5fb. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9f1d5fb in 1 minute and 36 seconds

More details
  • Looked at 37 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. docusaurus.config.ts:101
  • Draft comment:
    New 'GitHub' footer section added. Ensure the URLs remain consistent with the rest of the documentation infrastructure and consider extracting common URL constants if reused elsewhere.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50%
    While the suggestion about extracting constants could be valid since URLs are repeated (e.g., marketplace URL appears in navbar and footer), this seems more like a nice-to-have refactoring suggestion rather than a critical issue. The comment is also speculative with "if reused elsewhere" and doesn't point to specific instances where URLs are inconsistent.
    The suggestion to extract constants could improve maintainability. There is some URL reuse that could benefit from centralization.
    However, the comment is not specific enough about which URLs need to be extracted and doesn't point to any actual inconsistencies. It's more of a general suggestion than a concrete issue.
    Delete the comment as it's not specific enough and doesn't point to actual problems. If URL inconsistencies exist, they should be pointed out explicitly.
2. docusaurus.config.ts:113
  • Draft comment:
    New 'Download' footer section added. Confirm that the links to VS Code Marketplace and Open VSX Registry are up-to-date and correct.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is asking the PR author to confirm the correctness of links, which violates the rule against asking for confirmation or double-checking. It does not provide a specific code suggestion or request for tests.
3. docusaurus.config.ts:101
  • Draft comment:
    Footer 'GitHub' section added. Please verify that duplicating GitHub links (given a GitHub link already exists in the navbar) is intentional. Also, per Development Standards, consider enriching the commit message and PR description with more context on why these links were added.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50%
    None
4. docusaurus.config.ts:114
  • Draft comment:
    Footer 'Download' section added with VS Code Marketplace and Open VSX Registry links. Confirm that showing the VS Code Marketplace link in both the navbar and footer is intended. In the future, consider extracting repeated link configurations to a shared constant if similar patterns persist.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50%
    None

Workflow ID: wflow_RBZhWJHcX3abxEhp


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@mrubens mrubens merged commit 4775b93 into main Feb 15, 2025
2 checks passed
@mrubens mrubens deleted the better_footer branch February 15, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants