Skip to content

Update bedrock.md#51

Merged
mrubens merged 1 commit intomainfrom
mrubens-patch-2
Feb 20, 2025
Merged

Update bedrock.md#51
mrubens merged 1 commit intomainfrom
mrubens-patch-2

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Feb 20, 2025

Important

Update bedrock.md to correct documentation links and refine AWS configuration instructions.

  • Documentation Updates:
    • Update link for Bedrock access details to getting-started.html in bedrock.md.
    • Update link for model IDs to models-supported.html in bedrock.md.
  • Configuration Instructions:
    • Remove instructions to leave AWS Profile fields blank when using AWS Credentials in bedrock.md.
    • Remove instructions to leave Access Key, Secret Key, and Session Token fields blank when using AWS Profile in bedrock.md.

This description was created by Ellipsis for 42f0d9b. It will automatically update as commits are pushed.

@mrubens mrubens merged commit b0df69b into main Feb 20, 2025
1 check passed
@mrubens mrubens deleted the mrubens-patch-2 branch February 20, 2025 16:41
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 42f0d9b in 1 minute and 13 seconds

More details
  • Looked at 41 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 8 drafted comments based on config settings.
1. docs/providers/bedrock.md:10
  • Draft comment:
    Link update: Verify that replacing the access link to the AWS Bedrock documentation (from 'model-access.html' to 'getting-started.html') still provides the required access request procedures. This change could confuse users if 'getting-started.html' doesn’t cover access details.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    The comment is asking the PR author to verify a change, which violates the rule against asking for confirmation or verification. It also doesn't provide a specific code suggestion or ask for a test to be written. Therefore, it should be removed.
2. docs/providers/bedrock.md:52
  • Draft comment:
    Link update: The reference to the model list changed to 'models-supported.html'. Ensure that this link accurately reflects the current and complete list of available models.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    The comment is purely informative, asking the author to ensure the link is accurate. It doesn't provide a specific suggestion or point out a potential issue with the code.
3. docs/providers/bedrock.md:59
  • Draft comment:
    Configuration instructions: The removal of guidance for 'Use AWS Profile' (e.g., unchecked/checked status) may reduce clarity. Consider adding a note clarifying which fields should be filled out based on whether AWS Credentials or AWS Profile is used.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. docs/providers/bedrock.md:74
  • Draft comment:
    Prompt Caching removal: Confirm if prompt caching is deprecated or if additional context should be provided before its removal, as previous versions mentioned AWS's implementation.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. docs/providers/bedrock.md:10
  • Draft comment:
    Updated the Bedrock access link to use 'getting-started.html'. Ensure this URL directs users to the correct instructions for requesting access.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is asking the PR author to ensure that the URL directs users to the correct instructions. This falls under the rule of not asking the author to confirm or ensure behavior, which is not allowed.
6. docs/providers/bedrock.md:52
  • Draft comment:
    Updated supported models link to 'models-supported.html'. Confirm that this URL displays the up-to-date list of models along with their IDs.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    The comment is asking the PR author to confirm that the URL displays the correct information. This violates the rule against asking the PR author to confirm or double-check things.
7. docs/providers/bedrock.md:59
  • Draft comment:
    The detailed AWS Profile instructions have been removed from the 'AWS Credentials' section. Confirm that this information is provided elsewhere if needed.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is asking the PR author to confirm if the information is provided elsewhere, which violates the rule against asking for confirmation or explanation. It doesn't provide a specific code suggestion or point out a clear issue with the code.
8. docs/providers/bedrock.md:73
  • Draft comment:
    Add a newline at the end of the file to adhere to best practices.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_KPI4IActWMx6aSjT


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant