Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Jan 28, 2026

Fixes EXT-672: The execute_command UI now accurately shows the state of the terminal session.

Problem

The execute_command UI always showed "Running" regardless of whether the command was still executing or had already completed. The icon would change (spinner vs terminal icon), but the text never reflected the actual state.

Solution

Modified ChatRow.tsx to show:

  • "Running" when a command is actively executing (with spinner icon)
  • "Executed" when the command has completed (with terminal icon)

Added the "executed" translation key to all 18 locale files with appropriate translations.

Changes

  • webview-ui/src/components/chat/ChatRow.tsx - Conditional title based on isCommandExecuting
  • webview-ui/src/i18n/locales/*/chat.json - Added "executed" key to all locales

View task on Roo Code Cloud


Important

Fixes execute_command UI to accurately display "Running" or "Executed" based on command state in ChatRow.tsx, with localization updates.

  • Behavior:
    • ChatRow.tsx now conditionally displays "Running" or "Executed" based on isCommandExecuting.
    • Spinner icon for "Running" and terminal icon for "Executed".
  • Localization:
    • Added "executed" translation key to all 18 locale files.
  • Files:
    • ChatRow.tsx updated for conditional text display.
    • locales/*/chat.json updated with "executed" key.

This description was created by Ellipsis for c3f23c5. You can customize this summary. It will automatically update as commits are pushed.

EXT-672: The execute_command UI now accurately shows the terminal state:
- Shows "Running" when a command is actively executing
- Shows "Executed" when the command has completed

Added "executed" translation key to all 18 locale files.
@roomote
Copy link
Contributor Author

roomote bot commented Jan 28, 2026

Rooviewer Clock   See task on Roo Cloud

Review completed. No issues found.

The PR correctly aligns the command execution title text with the existing icon state logic. The isCommandExecuting conditional now determines both the icon (spinner vs terminal) and the text ("Running" vs "Executed"), ensuring UI consistency. All 18 locale files have been updated with appropriate translations.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant