Revert "refactor: replace fetch_instructions with skill tool and built-in skills" #11083
Conversation
…t-in ski…" This reverts commit 67e568f.
dosubot
bot
added
size:XXL
Reviewed; left inline comments for a couple of correctness/maintainability issues to address before merge.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
|
🚀 Preview deployed! Your changes have been deployed to Vercel: Preview URL: https://roo-code-website-prc0ovgv5-roo-code.vercel.app This preview will be updated automatically when you push new commits to this PR. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| const provider = task.providerRef.deref() | ||
| const mcpHub = provider?.getMcpHub() | ||
|
|
||
| if (!mcpHub) { |
There was a problem hiding this comment.
fetch_instructions currently throws when MCP is disabled because it always requires provider.getMcpHub(). create_mode instructions do not depend on MCP, so this makes fetch_instructions unusable in non-MCP setups. Consider only requiring mcpHub for create_mcp_server, and letting create_mode work without MCP enabled.
Fix it with Roo Code or mention @roomote and request a fix.
hannesrudolph
deleted the
revert-10913-refactor/replace-fetch-instructions-with-built-in-skills
branch
Reverts #10913
Bad merge resolve robbed functionality of PR #10844