Skip to content

Commit

Permalink
Ignore request_type and response_type in header parsing
Browse files Browse the repository at this point in the history
  • Loading branch information
carter committed Oct 29, 2024
1 parent 9f278be commit aa4f44d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- Generated code now includes various lint attributes to suppress warnings.
- TCPROS header parsing now ignores (the undocumented fields) response_type and request_type and doesn't produce warnings on them.

### Changed

Expand Down
4 changes: 4 additions & 0 deletions roslibrust/src/ros1/tcpros.rs
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ impl ConnectionHeader {
// for the purpose of discovering the service type
// If you do `rosservice call /my_service` and hit TAB you'll see this field in the connection header
// we can ignore it
} else if field.starts_with("response_type=") || field.starts_with("request_type=") {
// More undocumented fields!
// Discovered in testing that some roscpp service servers will set these on service responses
// We can ignore em
} else if field.starts_with("error=") {
log::error!("Error reported in TCPROS connection header: {field}, full header: {header_data:#?}");
} else {
Expand Down

0 comments on commit aa4f44d

Please sign in to comment.