Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init Translations #124

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

JakobDev
Copy link
Contributor

This PR adds initial Support for translations. It's alrady fully working, but you need to prepare your code a little. On Every string that should be translated replace

"my String"

with

tr("my String")

If you have something in your ui files that should not be translated e.g. a Placeholder text, you should mark it as not translatable.

You can add new languages by running

lupdate . -ts ./Translations/RMG_de.ts

In the Source directory

It can also be used with Weblate

I added a German translation with currently only includes the About Dialog as Example.

@Rosalie241
Copy link
Owner

I'm sorry it took so long for me to get to taking a look at this, life has (and still is) rather busy due to moving out.

If I merge this and make those required changes, will you finish the German translation?

@JakobDev
Copy link
Contributor Author

If I merge this and make those required changes, will you finish the German translation?

Yes

In case you're interested, I could also make a PR to use gettext with the .desktop and .appdata file, so they could also be intrated into Weblate

@JakobDev
Copy link
Contributor Author

Ping @Rosalie241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants