Skip to content

Conversation

@ekgns33
Copy link
Contributor

@ekgns33 ekgns33 commented May 6, 2025

작업내역

  • 테스트 편의성을 위해 테스트용 로그인/회원가입 API를 추가했습니다.
  • swagger-ui-host를 .env 및 application.yml로 관리하도록 수정했습니다.

Summary by CodeRabbit

  • New Features
    • Added test and development-only authentication endpoints for login and signup, enabling simulated user authentication flows in non-production environments.
  • Improvements
    • Made Swagger UI server URL configurable through application settings for flexible environment adaptation.
  • Chores
    • Updated application configuration to support dynamic Swagger UI server URL setup.

@ekgns33 ekgns33 requested a review from jeeheaG May 6, 2025 14:00
@ekgns33 ekgns33 self-assigned this May 6, 2025
@ekgns33 ekgns33 added the enhancement New feature or request label May 6, 2025
@coderabbitai
Copy link

coderabbitai bot commented May 6, 2025

Walkthrough

A test and development-only authentication API was introduced, including a REST controller, service, request and response DTOs. The controller exposes /login and /signup endpoints, which delegate to a service for user authentication and registration, returning JWT tokens. Additionally, Swagger server URL configuration was externalized to application properties. Test and main application YAML files were updated to support this configuration and adjust datasource and JPA settings for test environment.

Changes

File(s) Change Summary
src/main/java/org/runimo/runimo/auth/test/TestAuthController.java
TestAuthService.java
Introduced a test/dev-only REST controller and service for authentication, with endpoints for user login and signup, returning JWT tokens.
src/main/java/org/runimo/runimo/auth/test/TestAuthRequest.java
TestAuthResponse.java
Added immutable DTO records for authentication request and response, carrying user ID and token pair, respectively.
src/main/java/org/runimo/runimo/config/SwaggerConfig.java Modified Swagger configuration to inject server URL from application properties instead of hardcoding.
src/main/resources/application.yml Added a configuration property (runimo.server.ui.path) for the Swagger server URL, referencing an environment variable with a default fallback.
src/test/resources/application.yml Extended runimo.server.ui.path property for Swagger server URL; reordered datasource URL parameters; removed Hibernate dialect setting; cleared SQL data initialization location.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant TestAuthController
    participant TestAuthService
    participant UserRepository
    participant JwtTokenFactory

    Client->>TestAuthController: POST /api/v1/auth/test/login {userId}
    TestAuthController->>TestAuthService: login(userId)
    TestAuthService->>UserRepository: findById(userId)
    alt User found
        TestAuthService->>JwtTokenFactory: generateTokenPair(user)
        TestAuthService-->>TestAuthController: TestAuthResponse(tokens)
        TestAuthController-->>Client: SuccessResponse<TestAuthResponse>
    else User not found
        TestAuthService-->>TestAuthController: throw SignUpException
        TestAuthController-->>Client: Error response
    end

    Client->>TestAuthController: POST /api/v1/auth/test/signup
    TestAuthController->>TestAuthService: signUp()
    TestAuthService->>UserRepository: save(newUser)
    TestAuthService->>JwtTokenFactory: generateTokenPair(newUser)
    TestAuthService-->>TestAuthController: TestAuthResponse(tokens)
    TestAuthController-->>Client: SuccessResponse<TestAuthResponse>
Loading

Poem

In test and dev, new doors appear,
Login and signup now draw near.
Tokens hop from service to paw,
Swagger’s path set by config law.
With every change, this bunny grins—
For smoother tests, let joy begin!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between d9b3d79 and d8de141.

📒 Files selected for processing (1)
  • src/test/resources/application.yml (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/test/resources/application.yml

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ekgns33 ekgns33 merged commit a9ee95a into main May 7, 2025
3 checks passed
@ekgns33 ekgns33 deleted the feat/test-api branch May 7, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant