Skip to content

[Feat/add description to record] #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ekgns33 merged 2 commits into from
May 8, 2025
Merged

[Feat/add description to record] #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab92338
:sparkles: feat : add description, img_url to detail response
ekgns33 May 8, 2025
60d0d2c
:white_check_mark: test : add validation for response
ekgns33 May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/org/runimo/runimo/records/service/usecases/dtos/RecordDetailViewResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ public record RecordDetailViewResponse(
String recordId,
@Schema(description = "기록 제목")
String title,
@Schema(description = "기록 설명")
String description,
@Schema(description = "기록 시작 시간")
LocalDateTime startedAt,
LocalDateTime endAt,
Expand All @@ -32,6 +34,8 @@ public static RecordDetailViewResponse from(final RunningRecord runningRecord) {
return RecordDetailViewResponse.builder()
.recordId(runningRecord.getRecordPublicId())
.title(runningRecord.getTitle())
.description(runningRecord.getDescription())
.imgUrl(runningRecord.getImgUrl())
.startedAt(runningRecord.getStartedAt())
.endAt(runningRecord.getEndAt())
.totalRunningTime(runningRecord.getRunningTime().getSeconds())
Expand Down
14 changes: 14 additions & 0 deletions src/test/java/org/runimo/runimo/records/api/RecordAcceptanceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,20 @@ void tearDown() {
.patch("/api/v1/records/record-public-id-1")
.then()
.statusCode(HttpStatus.OK.value());

given()
.header("Authorization", token)
.contentType(ContentType.JSON)
.when()
.get("/api/v1/records/{recordId}", "record-public-id-1")
.then()
.log().all()
.statusCode(200)
.body("payload.record_id", notNullValue())
.body("payload.title", equalTo("예시 제목"))
.body("payload.description", equalTo("오늘은 올림픽 공원을 달렸어요."))
.body("payload.img_url", equalTo("https://example.com/image.jpg"));

}
}