Skip to content

fix: use namespace import for os in main constants #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reachraza merged 3 commits into from
Mar 13, 2026
Merged

fix: use namespace import for os in main constants #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10b9b1a
fix: use namespace import for os in main constants
jeffscottward Mar 11, 2026
8315ebf
fix: use node os import in main constants
jeffscottward Mar 11, 2026
08a7ed2
test: stabilize agent configuration hook timing
jeffscottward Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/__tests__/renderer/hooks/useAgentConfiguration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,10 +254,8 @@ describe('useAgentConfiguration', () => {
});

await waitFor(() => {
expect(mockGetConfig).toHaveBeenCalledWith('claude-code');
expect(result.current.agentConfig).toEqual({ model: 'opus' });
});

expect(result.current.agentConfig).toEqual({ model: 'opus' });
});
});

Expand Down
2 changes: 1 addition & 1 deletion src/main/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/

import path from 'path';
Copy link

@greptile-apps greptile-apps bot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent import style with path

The os import has been updated to namespace style (* as os) to fix the Node 22 / Vitest SSR issue, but the path import on the line above still uses the default import style. Since both path and os are Node built-in modules and both are used together in the same module-level expression on line 85 (path.join(os.tmpdir(), ...)), aligning them to the same import style would be cleaner and guards against the same potential SSR interop issue for path.

Suggested change
import path from 'path';
import * as path from 'path';

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

import os from 'os';
import * as os from 'node:os';

// ============================================================================
// Pre-compiled Regex Patterns (Performance Optimization)
Expand Down