-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add demo mode to dashboard #107
base: master
Are you sure you want to change the base?
Conversation
Adding functionality to suppress "menu" for a "demo" mode. This will allow "pre-sales" to show dashboard in a publicly available app without worry about users starting heap dumps or profiles
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 60.6% 60.68% +0.07%
==========================================
Files 2 2
Lines 231 234 +3
==========================================
+ Hits 140 142 +2
- Misses 91 92 +1
Continue to review full report at Codecov.
|
@dashby3000 this seems like a good addition. I've renamed this PR as the title wasn't very clear. Will review along with #108. |
@dashby3000 if you remove the ability to switch profiling on then you should also remove the profiling tab since it's redundant. Alternatively we could keep the menu so that profiling can still be enabled but just remove or disable the NodeReport and HeapDump items. Also I'm not exactly sure how you created this PR but it wasn't easy for me to test your changes (I actually had to copy and paste from GitHub). In future it would be better to create a public fork and make the pull request from there. I'd like to see this PR combined with the contents of #108 and some new changes to either remove the profiling tab or keep the menu and remove the dump actions, all rolled in to one new PR made from a public fork. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes needed, as described in comment
Adding functionality to suppress "menu" for a "demo" mode. This will allow "pre-sales" to show dashboard in a publicly available app without worry about users starting heap dumps or profiles