Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add demo mode to dashboard #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add demo mode to dashboard #107

wants to merge 1 commit into from

Conversation

dashby3000
Copy link

Adding functionality to suppress "menu" for a "demo" mode. This will allow "pre-sales" to show dashboard in a publicly available app without worry about users starting heap dumps or profiles

Adding functionality to suppress "menu" for a "demo" mode.  This will allow "pre-sales" to show dashboard in a publicly available app without worry about users starting heap dumps or profiles
@codecov-io
Copy link

codecov-io commented Aug 26, 2017

Codecov Report

Merging #107 into master will increase coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage    60.6%   60.68%   +0.07%     
==========================================
  Files           2        2              
  Lines         231      234       +3     
==========================================
+ Hits          140      142       +2     
- Misses         91       92       +1
Impacted Files Coverage Δ
lib/appmetrics-dash.js 60.51% <66.66%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fab4ed...4fab7c3. Read the comment docs.

@sjanuary sjanuary changed the title Update appmetrics-dashby.js Add demo mode to dashboard Sep 26, 2017
@sjanuary
Copy link
Contributor

@dashby3000 this seems like a good addition. I've renamed this PR as the title wasn't very clear. Will review along with #108.

@sjanuary sjanuary self-requested a review September 26, 2017 10:33
@sjanuary
Copy link
Contributor

@dashby3000 if you remove the ability to switch profiling on then you should also remove the profiling tab since it's redundant. Alternatively we could keep the menu so that profiling can still be enabled but just remove or disable the NodeReport and HeapDump items.

Also I'm not exactly sure how you created this PR but it wasn't easy for me to test your changes (I actually had to copy and paste from GitHub). In future it would be better to create a public fork and make the pull request from there. I'd like to see this PR combined with the contents of #108 and some new changes to either remove the profiling tab or keep the menu and remove the dump actions, all rolled in to one new PR made from a public fork.

Copy link
Contributor

@sjanuary sjanuary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes needed, as described in comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants