Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: upgrade GCC baseline from 4.8 -> 5.4 (5.5) #3262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thesamesam
Copy link
Contributor

@thesamesam thesamesam commented Nov 22, 2024

GCC's baseline was changed from C++11 -> C++14 and GCC 4.8 -> GCC 5.4
in r15-4719-ga9ec1bc06bd3cc, so adjust the baseline CI job accordingly.

One quirk here is that the Ubuntu image we're using in CI has 5.5.0
rather than 5.4.0. But I think we can eat that difference.

ChangeLog:
* .github/workflows/ccpp.yml: Use GCC 5.5 instead of GCC 4.8.
* .github/bors.toml: Update CI job name.

@thesamesam thesamesam marked this pull request as draft November 22, 2024 21:24
@thesamesam thesamesam force-pushed the gcc-baseline branch 2 times, most recently from 834cfd7 to c9f480f Compare November 22, 2024 21:28
@tschwinge
Copy link
Member

Great, thanks! I was meaning to file an Issue for this -- now we've got a Pull Request already! :-D

@thesamesam thesamesam changed the title CI: upgrade GCC baseline from 4.8 -> 5.4 CI: upgrade GCC baseline from 4.8 -> 5.4 (5.5) Nov 23, 2024
@thesamesam thesamesam marked this pull request as ready for review November 23, 2024 00:33
thesamesam added a commit to thesamesam/gccrs that referenced this pull request Nov 23, 2024
This was pointed out by tschwinge in a review [0]. Add a note to avoid
that error happening in future.

[0] Rust-GCC#3262 (comment)

ChangeLog:
	* .github/workflows/ccpp.yml: Add note to keep in sync with
	.github/bors.toml.
.github/bors.toml Outdated Show resolved Hide resolved
@dkm
Copy link
Member

dkm commented Nov 23, 2024

I've removed all bors mention/files in #3263

GCC's baseline was changed from C++11 -> C++14 and GCC 4.8 -> GCC 5.4
in r15-4719-ga9ec1bc06bd3cc, so adjust the baseline CI job accordingly.

One quirk here is that the Ubuntu image we're using in CI has 5.5.0
rather than 5.4.0. But I think we can eat that difference.

ChangeLog:
	* .github/workflows/ccpp.yml: Use GCC 5.5 instead of GCC 4.8.
@powerboat9
Copy link
Contributor

powerboat9 commented Nov 23, 2024

It's not auto-merging, seemingly because build-and-check-gcc-48 no longer exists

@tschwinge
Copy link
Member

@powerboat9: Yeah, probably. Where does it get that from, do you (or anyone else, of course) happen to know?

I could easily push this manually, but not sure I should? Maybe wait for the pros to be back on Monday. ;-)

@dkm
Copy link
Member

dkm commented Nov 24, 2024

@powerboat9: Yeah, probably. Where does it get that from, do you (or anyone else, of course) happen to know?

I could easily push this manually, but not sure I should? Maybe wait for the pros to be back on Monday. ;-)

Looks like a known issue when renaming names in workflows (see https://github.com/orgs/community/discussions/42874 for example). build-and-check-gcc-5 is OK, so we can probably force the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants