-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: upgrade GCC baseline from 4.8 -> 5.4 (5.5) #3262
base: master
Are you sure you want to change the base?
Conversation
834cfd7
to
c9f480f
Compare
Great, thanks! I was meaning to file an Issue for this -- now we've got a Pull Request already! :-D |
c9f480f
to
df79b77
Compare
This was pointed out by tschwinge in a review [0]. Add a note to avoid that error happening in future. [0] Rust-GCC#3262 (comment) ChangeLog: * .github/workflows/ccpp.yml: Add note to keep in sync with .github/bors.toml.
I've removed all bors mention/files in #3263 |
a146b89
to
bf08887
Compare
GCC's baseline was changed from C++11 -> C++14 and GCC 4.8 -> GCC 5.4 in r15-4719-ga9ec1bc06bd3cc, so adjust the baseline CI job accordingly. One quirk here is that the Ubuntu image we're using in CI has 5.5.0 rather than 5.4.0. But I think we can eat that difference. ChangeLog: * .github/workflows/ccpp.yml: Use GCC 5.5 instead of GCC 4.8.
bf08887
to
699b987
Compare
It's not auto-merging, seemingly because |
@powerboat9: Yeah, probably. Where does it get that from, do you (or anyone else, of course) happen to know? I could easily push this manually, but not sure I should? Maybe wait for the pros to be back on Monday. ;-) |
Looks like a known issue when renaming names in workflows (see https://github.com/orgs/community/discussions/42874 for example). |
GCC's baseline was changed from C++11 -> C++14 and GCC 4.8 -> GCC 5.4
in r15-4719-ga9ec1bc06bd3cc, so adjust the baseline CI job accordingly.
One quirk here is that the Ubuntu image we're using in CI has 5.5.0
rather than 5.4.0. But I think we can eat that difference.
ChangeLog:
* .github/workflows/ccpp.yml: Use GCC 5.5 instead of GCC 4.8.
* .github/bors.toml: Update CI job name.