Scaffolding for running tests in CI #199
Merged
LegNeato merged 13 commits intoRust-GPU:mainfrom Apr 15, 2025
Merged
Conversation
For some reason I was just a CONTRIBUTOR. It is better to check write access anyway.
This doesn't appear to be interpolated if the step is not run.
LegNeato
changed the title
nnethercote
added a commit
to nnethercote/Rust-CUDA
that referenced
this pull request
Dec 9, 2025
It was added in Rust-GPU#199, in preparation for running GPU tests on non-GitHub resources. But that seems unlikely to happen now, so it's just added complexity and potential for unexplained failures (as seen in Rust-GPU#332). This commit removes it. We can always reinstate it if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm breaking up adding tests in CI so it doesn't get too big.
This is the scaffolding, it doesn't actually run any tests.
The reason for a different step is to gate tests so that secrets are not exposed on pull requests. Maintainers PRs and main get tests run automatically, but other wise the step is skipped (but can be trigger manually, once this is landed on main).