-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace printing codegen args with tracing
#196
base: main
Are you sure you want to change the base?
Conversation
bdde30b
to
8dc5c17
Compare
This removes the following options and replaces them with `tracing`: * `--specializer-debug` => RUSTGPU_LOG=rustc_codegen_spirv::specializer=debug * `--print-zombie` => RUSTGPU_LOG=print_zombie=debug * `--print-all-zombie` => RUSTGPU_LOG=print_all_zombie=debug
8dc5c17
to
0f38dad
Compare
Questions:
|
Suggestion: use the Profiling uses features to specify which profiler you want to use, and ofc it has |
I think that is a good idea, but this isn't for profiling--just logging debug data. Rustc uses tracing so I'd prefer to start with the same solution. Looks like |
I also found https://docs.rs/tracing-tracy/latest/tracing_tracy/. Not sure which way is ultimately better, will probably require some hands on experience. |
Looks like rustc has profiling built in, so we should probably use that for profiling I think. |
Depends on #193.
This removes the following options and replaces them with
tracing
:--specializer-debug
=> RUSTGPU_LOG=rustc_codegen_spirv::specializer=debug--print-zombie
=> RUSTGPU_LOG=print_zombie=debug--print-all-zombie
=> RUSTGPU_LOG=print_all_zombie=debug