add #[non_exhaustive] to SpirvBuilder and all dependent structs#265
Merged
Firestar99 merged 1 commit intomainfrom Jun 3, 2025
Merged
add #[non_exhaustive] to SpirvBuilder and all dependent structs#265Firestar99 merged 1 commit intomainfrom
#[non_exhaustive] to SpirvBuilder and all dependent structs#265Firestar99 merged 1 commit intomainfrom
Conversation
LegNeato
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some discussions on cargo-gpu, we decided that all public cargo gpu structs will be
#[non_exhaustive], even if that disallows users from using the struct update syntax. But as we reexportSpirvBuilder, we also need it and all of its member structs to be#[non_exhaustive].