ci: check test success for lint and cargo-deny #436
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
changed the title
Firestar99
force-pushed
the
ci-test-success
branch
from
1bd59d1 to
1eb9d97
Compare
LegNeato
approved these changes
Oct 12, 2025
eddyb
reviewed
Oct 13, 2025
Comment on lines
207
to
219
| needs: [test, compiletest, difftest, android] | ||
| needs: [test, compiletest, difftest, android, lint, cargo-deny] | ||
| # Hack for buggy GitHub Actions behavior with skipped checks: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks | ||
| if: ${{ always() }} | ||
| steps: | ||
| # Another hack is to actually check the status of the dependencies or else it'll fall through | ||
| - run: | | ||
| echo "Checking statuses..." | ||
| [[ "${{ needs.test.result }}" == "success" ]] || exit 1 | ||
| [[ "${{ needs.compiletest.result }}" == "success" ]] || exit 1 | ||
| [[ "${{ needs.difftest.result }}" == "success" ]] || exit 1 | ||
| [[ "${{ needs.android.result }}" == "success" ]] || exit 1 | ||
| [[ "${{ needs.lint.result }}" == "success" ]] || exit 1 | ||
| [[ "${{ needs.cargo-deny.result }}" == "success" ]] || exit 1 |
There was a problem hiding this comment.
I still can't believe GitHub Actions doesn't have a better way to do this (arguably quite basic?) "require all tests to pass" pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In abc684e I've made lint fail, but as you can see in the action,
test_successsucceeded, which would allow a PR to merge. This PR adds lint and cargo-deny to the required tests to succeed.