feat: add Sample::bits_per_sample() #1008
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had
Sample::sample_size()
which returns the size in bytes of a format. This does not always correspond with the number of bits. For example,I24
is stored in 4 bytes but with 24 bits storing audio, not 32. This PR introduces a new functionSample::bits_per_sample()
to do that.For
F32
orF64
we could argue what it should return. This method returns 32/64 bits of bit depth (storage) instead of 24/58 bits of precision (effective resolution).