fix: emoji search scroll area height#211
Merged
unsecretised merged 2 commits intoRustCastLabs:masterfrom Mar 23, 2026
Merged
Conversation
unsecretised
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix to emoji scroll area height.
What changed?
Before: Page::EmojiSearch used heigh based on
results.len() * 60which isn't accurate because emojis are displayed in rows of 6 and are larger than normal search itemsAfter: Scroll area height for EmojiSearch is now based on
((tile.results.len() + 6 - 1) / 6) * 90which is equivalent to taking the ceiling oftile.results.len() / 6then multiplying by 90 (70 for emoji height and 20 for padding)