Fixed ML-KEM benches #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aah, I see what was happening: they're tested in CI here: https://github.com/RustCrypto/KEMs/blob/master/.github/workflows/ml-kem.yml#L67 But that's running I think this change is fine, but we should also update the CI config to ensure |
|
Ah makes sense. Ok I’ll do that |
|
Done |
tarcieri
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benches weren't compiling. They were using non-public deterministic functions. Now they use the random functions. Also I removed key parsing from the encap and decap functions. IMO they should just be doing encap/decap, but I can add ser/deser back in if you think it really belongs there.