Repository navigation
Conversation
`Option::from(CtOption)` branches on `is_some`, which leaks whether the value is invertible. Use `CtOption::unwrap_or`, which selects in constant time. Add a test for the non-invertible path.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1355 +/- ##
=======================================
Coverage 91.28% 91.28%
=======================================
Files 190 190
Lines 22941 22947 +6
=======================================
+ Hits 20942 20948 +6
Misses 1999 1999 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function already returns
CtOption::new(ret, is_some)and avoids branching onself.params.inverter().invert(&self.montgomery_form);result, so this does the same for the attachedBoxedMontyForm