tls_codec: implement SerializeBytes for VLBytes - #2350
Merged
franziskuskiefer merged 4 commits intoJun 18, 2026
Conversation
franziskuskiefer
self-requested a review
June 17, 2026 08:29
wysiwys
force-pushed
the
wysiwys/vlbytes_serialize_bytes
branch
from
June 17, 2026 08:39
e8079de to
72df2d8
Compare
franziskuskiefer
changed the title
SerializeBytes for VLBytesSerializeBytes for VLBytes
franziskuskiefer
requested changes
Jun 18, 2026
franziskuskiefer
left a comment
franziskuskiefer
left a comment
Contributor
There was a problem hiding this comment.
Thanks.
This creates an asymmetry for no_std. I don't think that's necessary.
You could implement it the way &[T] already does it, and move both impls out to a location that is not gated by std.
franziskuskiefer
requested changes
Jun 18, 2026
franziskuskiefer
left a comment
franziskuskiefer
left a comment
Contributor
There was a problem hiding this comment.
Looks like CI isn't happy.
wysiwys
force-pushed
the
wysiwys/vlbytes_serialize_bytes
branch
from
June 18, 2026 13:24
60f5127 to
ff50d18
Compare
franziskuskiefer
approved these changes
Jun 18, 2026
franziskuskiefer
left a comment
franziskuskiefer
left a comment
Contributor
There was a problem hiding this comment.
Thanks, let's get this in.
Just a note that VLByteVec is replacing VLBytes (hence the deprecation).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
SerializeBytesforVLBytes. Since theSerializeBytes::tls_serialize()method is now implemented forVLBytesin addition to the existingSerialize::tls_serialize()method, this PR also updates the calls toSerialize::tls_serialize()in this module to explicitly use the method from theSerializetrait.