ecdsa: re-export blobby #1082
ecdsa: re-export blobby #1082
Conversation
|
This issue surfaced in the upgrade of blobby (0.3 -> 0.4) in elliptic-curves: RustCrypto/elliptic-curves#1483 |
baloo
force-pushed
the
baloo/ecdsa/re-export-blobby
branch
3 times, most recently
from
a04804b to
6caa730
Compare
|
cc @newpavlov any chance you could take a look at this one? (and its companion followup RustCrypto/elliptic-curves#1484) |
|
@baloo it generally looks fine to me, I can look in a bit |
There was a problem hiding this comment.
Note that you could re-export blobby from digest::dev instead of making it a direct dependency.
|
oh, let me do that then. |
baloo
force-pushed
the
baloo/ecdsa/re-export-blobby
branch
from
6caa730 to
11c6a59
Compare
|
Hm, or maybe we should re-export it from I don't have a strong opinion here, so feel free to select anything you like. |
|
it gets pulled with EDIT: Which means I can cleanup my cfg in the tests. |
Re-exporting blobby directly from ecdsa makes version upgrades a tiny bit more resilient to API changes made in blobby. They otherwise have to be carefully managed between ecdsa and its dependencies. If the binary format changes between the blobby upgrade, the blob files will still need to be updated to match.
baloo
force-pushed
the
baloo/ecdsa/re-export-blobby
branch
from
11c6a59 to
b45f2ed
Compare
|
Anything remaining here? |
Co-authored-by: Tony Arcieri <[email protected]>
3 participants
Re-exporting blobby directly from ecdsa makes version upgrades a tiny bit more resilient to API changes made in blobby.
They otherwise have to be carefully managed between ecdsa and its dependencies.
If the binary format changes between the blobby upgrade, the blob files will still need to be updated to match.