fix: add history.replaceState to clearAllFilters to clean URL on rese…#1952
fix: add history.replaceState to clearAllFilters to clean URL on rese…#1952Rudrasamadhiya wants to merge 1 commit into
Conversation
closes S3DFX-CYBER#1053) Updated history state management to reset URL parameters before applying filters.
|
@Rudrasamadhiya is attempting to deploy a commit to the s3dfx-cyber's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
💬 Faster Reviews & AssignmentsHi @Rudrasamadhiya, for faster coordination and smoother communication, consider joining our Discord community: Useful Channels
|
👋 Thanks for opening a PR, @Rudrasamadhiya!Your PR has entered the 🚦 PR Review Pipeline.
🔄 Review Flow
A pipeline status comment may appear automatically as your PR progresses. ✅ Contributor Checklist
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🔇 Additional comments (1)
📝 WalkthroughSummary by CodeRabbitBug Fixes
WalkthroughIn ChangesURL Reset on Filter Clear
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🤖 TENET Agent Review📋 SummaryThis PR addresses a client-side bug where clearing filters did not update the URL, causing previously cleared filters to reappear upon refresh or sharing. The fix correctly implements 🔐 Security FindingsNo security issues found. 🧹 Code Quality
✅ What's Done Well
📝 Overall Verdict[APPROVE] - The fix is correct, improves user experience, and introduces no security concerns. |
|
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Modifies browser history handling to fix URL persistence after clearing filters, a user-facing change that could affect navigation and sharing. It should be reviewed to avoid any side effects.
Re-trigger cubic
✅ Merge Conflicts ResolvedThanks @Rudrasamadhiya, this PR is mergeable again. |



Fixes #1053
Summary
clearAllFilters()inindex.htmlwas missinghistory.replaceState()to clean the URL after resetting filters. This caused stale URL params to persist, so sharing or refreshing after clearing would restore all supposedly cleared filters.Changes
history.replaceState(null, '', location.pathname)beforeapplyFilters()inclearAllFilters()to clean the URL query string on reset