Skip to content

Fix PWA icon manifest dimension mismatch#2000

Open
lekhanpro wants to merge 1 commit into
S3DFX-CYBER:mainfrom
lekhanpro:gssoc-1699-fix-pwa-icon-size
Open

Fix PWA icon manifest dimension mismatch#2000
lekhanpro wants to merge 1 commit into
S3DFX-CYBER:mainfrom
lekhanpro:gssoc-1699-fix-pwa-icon-size

Conversation

@lekhanpro

@lekhanpro lekhanpro commented Jul 6, 2026

Copy link
Copy Markdown

Summary

  • Replaces src/assets/icon-512.png with a true 512x512 PNG
  • Keeps the existing manifest entries unchanged because their declared 512x512 size now matches the asset
  • Resolves the Chrome DevTools PWA manifest warning about actual icon dimensions

Closes #1699

Tests

  • Manifest/icon validation: src/assets/icon-512.png manifest=512x512 actual=512x512 for both icon entries
  • npm test

Review in cubic

@lekhanpro
lekhanpro requested a review from S3DFX-CYBER as a code owner July 6, 2026 17:37
@vercel

vercel Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@lekhanpro is attempting to deploy a commit to the s3dfx-cyber's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

⚠️ PR Validation Issues

Hi @lekhanpro, your PR requires fixes before review.

Warnings

  • ⚠️ Missing contribution program declaration (GSSOC or NSOC).
  • ⚠️ Missing PR template section: related issue
  • ⚠️ Missing PR template section: type of change
  • ⚠️ Missing PR template section: checklist
  • ⚠️ PR title must follow conventional commits. Example: feat: improve mobile navbar

Please push fixes after updating the PR.

@github-actions github-actions Bot added dco-missing bug Something isn't working frontend gssoc26 GirlScript Summer of Code 2026 labels Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

💬 Faster Reviews & Assignments

Hi @lekhanpro, for faster coordination and smoother communication, consider joining our Discord community:

👉 https://discord.gg/MmZGG2ee

Useful Channels

  • #issue-links-for-assignment → Share issue links for assignment help
  • #pr-links-for-review → Share PR links for mentor/maintainer review

Please avoid spamming channels or repeatedly pinging mentors/maintainers.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

✅ DCO Sign-off Verified

Hi @lekhanpro 👋

All commits in this PR contain valid Signed-off-by lines.

Thank you for following the DCO requirements 🚀

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

👋 Thanks for opening a PR, @lekhanpro!

Your PR has entered the 🚦 PR Review Pipeline.

🟢 GSSOC PR detected — your PR will be routed through the GSSOC mentor review pipeline.


🔄 Review Flow

Stage Reviewer Purpose
Stage 1 🤖 Automation Validation · Duplicate Detection · AI/Slop Checks · Formatting · PR Analysis
Stage 2 🧑‍🏫 GSSOC Mentor Code Review · Scope Validation · Quality Check
Stage 3 🔑 Project Admin / Maintainer Final Approval & Merge Decision

The automated PR analysis system will verify issue linkage, PR relevance, and contribution quality.

A pipeline status comment may appear automatically as your PR progresses.


✅ Contributor Checklist

  • Sign commits using git commit -s
  • Link a valid issue (Closes #123)
  • Keep changes focused and relevant
  • Do not include unrelated modifications
  • Ensure workflows/build/tests are passing
  • Read the appropriate contributor guide:

⚠️ Important Notes

  • Low-quality, spammy, or AI-generated PRs may be closed
  • PRs without linked issues may fail automated checks
  • Large unrelated PRs are likely to be rejected
  • Review times may vary depending on mentor/reviewer availability

Happy contributing 🚀

This message is posted automatically and only once.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • src/assets/icon-512.png is excluded by !**/*.png

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 34bd7756-5822-4b08-8f9f-4ac3634be322

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot removed the gssoc26 GirlScript Summer of Code 2026 label Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🤖 TENET Agent Review

📋 Summary

This PR replaces the src/assets/icon-512.png file with a correctly sized 512x512 PNG image. This change resolves a Chrome DevTools PWA manifest warning regarding dimension mismatches for the PWA icon, improving the application's PWA compliance. The approach is sound and directly addresses the described issue.

🔐 Security Findings

No security issues found.

🧹 Code Quality

Code quality looks good.

✅ What's Done Well

  • Addresses a specific PWA compliance issue: The PR directly fixes a PWA manifest warning, improving the application's overall PWA quality.
  • Clear description and testing: The PR description clearly outlines the problem and solution, and the testing steps are appropriate for validating the fix.

📝 Overall Verdict

[APPROVE] - The PR correctly fixes a PWA icon dimension mismatch with no security or code quality concerns.


Review powered by TENET Agent 🛡️ | Triggered automatically on PR #2000

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🚦 PR Review Pipeline

Standard PR

Stage Status
Stage 1 — Automated Checks ✅ All automated checks passed
Stage 2 — Mentor/Reviewer ⏳ Awaiting reviewer approval
Stage 3 — Maintainer 🔒 Blocked until Stage 2 passes

No active issues


Last updated: Mon, 06 Jul 2026 17:38:15 GMT

Signed-off-by: lekhan <lekhan2007@gmail.com>
@lekhanpro
lekhanpro force-pushed the gssoc-1699-fix-pwa-icon-size branch from a51c64f to dde3e95 Compare July 6, 2026 17:37
@github-actions github-actions Bot added dco-verified gssoc26 GirlScript Summer of Code 2026 stage-1-approved and removed dco-missing gssoc26 GirlScript Summer of Code 2026 needs-stage-1-fixes labels Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🤖 TENET Agent Review

📋 Summary

This pull request addresses a PWA manifest warning in Chrome DevTools by replacing the src/assets/icon-512.png asset with a version that correctly matches the declared 512x512 dimensions. The approach is sound as it directly resolves the reported dimension mismatch without altering the manifest entries themselves.

🔐 Security Findings

No security issues found. The change is limited to a binary image asset and does not introduce new code, dependencies, or modify security-sensitive logic.

🧹 Code Quality

Code quality looks good. The PR involves a binary asset update, so traditional code quality metrics are not applicable.

✅ What's Done Well

  • Directly addresses a known issue: The PR resolves a specific PWA manifest warning, improving the application's adherence to PWA standards.
  • Ensures consistency: It correctly aligns the actual asset dimensions with the manifest's declared dimensions.
  • Clear description: The PR description clearly outlines the problem, solution, and verification steps.

📝 Overall Verdict

[APPROVE] - The change is a straightforward fix for a PWA warning and has no security or functional regressions.


Review powered by TENET Agent 🛡️ | Triggered automatically on PR #2000

@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

@lekhanpro

Copy link
Copy Markdown
Author

Hi maintainers, this PR closes GSSoC-approved issue #1699. The linked issue has gssoc:approved, but the PR label sync did not copy that label. Could you please add gssoc:approved before review/merge so the contribution is tracked correctly for GSSoC?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

[BUG] PWA manifest declares icon-512.png as 512×512 but asset is actually 1024×1024

1 participant